Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR replaces the existing log::debug! calls with the new tower_telemetry::debug! macro and wires in the tower-telemetry crate as the logging backend, while also removing the old log and simple_logger dependencies. Tests and runtime behavior remain unchanged; the main impacts are on how debug traces are emitted.
- Swapped
log::debug!invocations fordebug!fromtower_telemetryacross all crates. - Removed
logandsimple_loggerdependencies and addedtower-telemetryeverywhere. - Updated the
AppLauncher::launchcall to accept a newContextparameter, and switched toenable_logging.
Reviewed Changes
Copilot reviewed 31 out of 31 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| crates/tower-package/src/lib.rs | Imported tower_telemetry::debug; replaced log::debug |
| crates/tower-package/src/error.rs | Ditto for error conversions |
| crates/tower-package/Cargo.toml | Removed log, added tower-telemetry |
| crates/tower-cmd/src/util/deploy.rs | Replaced log::debug and imported debug |
| crates/tower-cmd/src/teams.rs | Ditto |
| crates/tower-cmd/src/session.rs | Ditto |
| crates/tower-cmd/src/secrets.rs | Ditto |
| crates/tower-cmd/src/run.rs | Replaced log::debug, imported Context, debug, updated .launch |
| crates/tower-cmd/src/output.rs | Replaced log::debug in error handling |
| crates/tower-cmd/src/lib.rs | Removed simple_logger, replaced set_max_level with enable_logging |
| crates/tower-cmd/src/error.rs | Ditto for crypto error |
| crates/tower-cmd/src/deploy.rs | Ditto |
| crates/tower-cmd/src/api.rs | Ditto for API traces |
| crates/tower-cmd/Cargo.toml | Removed logging crates, added tower-telemetry |
| crates/tower-api/Cargo.toml | Removed log, added tower-telemetry |
| crates/config/src/towerfile.rs | Replaced log::debug |
| crates/config/src/session.rs | Ditto |
| crates/config/src/error.rs | Removed extra println!, now only debug! |
| crates/config/Cargo.toml | Removed log, added tower-telemetry |
| Cargo.toml | Removed global log and simple_logger, added tracing deps |
Comments suppressed due to low confidence (2)
crates/config/src/error.rs:47
- [nitpick] The original
println!for TOML parsing errors was removed, so end users no longer see the raw error. If this message is still helpful for troubleshooting when debug logging is disabled, consider emitting a user-facing error or restoring a visible output path.
debug!("error parsing Towerfile Toml: {}", err);
crates/tower-cmd/src/run.rs:134
- The signature of
AppLauncher::launchwas modified to includeContext::new()as the first argument; verify that this matches the updated API definition and update any documentation or trait implementations that expect the old signature.
.launch(Context::new(), sender, package, env, secrets, params, catalogs)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.