🐛 fix(ci): unbreak pre-commit and finish zizmor lockdown#26
Merged
Conversation
Indentation in .pre-commit-config.yaml mixed two-space and four-space styles, so pre-commit failed to parse it. Normalize to two-space. Also resolve zizmor findings that PR tox-dev#25 missed in action.yml and dependabot.yaml: pin third-party actions to SHA, move inputs.extra_args into the env block to avoid template injection, and add a Dependabot cooldown. Rename the workflow jobs from main-* to self-test-* and add a top-level 'CI' name so PR status checks are self-describing.
gaborbernat
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CI on
mainis red for every job because thezizmorhook added in #25 cannot parse.pre-commit-config.yaml. The file mixes 2- and 4-space list indentation, so pre-commit aborts withInvalidConfigErrorbefore any hook runs. 🔧#25 also enabled
zizmorwithout running it againstaction.ymlor.github/dependabot.yaml, which carry five real findings:astral-sh/setup-uvandactions/cacheare referenced by floating tag rather than commit SHA,${{ inputs.extra_args }}is interpolated directly into arun:block (template injection), and the Dependabot config has nocooldown. Pinning to SHAs matches the policy already applied in.github/workflows/main.yml. Movinginputs.extra_argsinto the step'senv:and referencing it as${INPUTS_EXTRA_ARGS}removes the injection path while preserving word splitting, so callers passing multiple flags keep working.The workflow jobs are also renamed from
main-*toself-test-*and the workflow gains a top-levelname: CI, so PR status checks read asCI / self-test-uvxinstead ofmain / main-uvx. ✨