Fix for NetworkSettings api change (docker engine >=29.0.0)#197
Open
altaurog wants to merge 2 commits intotox-dev:masterfrom
Open
Fix for NetworkSettings api change (docker engine >=29.0.0)#197altaurog wants to merge 2 commits intotox-dev:masterfrom
altaurog wants to merge 2 commits intotox-dev:masterfrom
Conversation
The old, deprecated interface was removed in docker 29.0.0, 2025-11-10
altaurog
changed the title
altaurog
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
get_gateway_iprelies onNetworkSettings.Gateway, which has been deprecated for over ten years. This field was removed in docker 29.0.0, released on 2025-11-10. This fix favors the new API data schema so as to work with the latest versions of docker engine. Quite possibly the old interface code could be removed altogether.An open question is whether reliable support is required for a scenario in which the container has multiple networks, in which case preference should presumably be given to specific networks and not necessarily the first network listed.