Conversation
Reviewer's GuideThis PR adds CI and conda-build support for Python 3.13 and 3.14, updates the CMake build to use modern Python introspection and link APIs, and refines the conda recipe and build scripts to better support newer Python and macOS targets. Flow diagram for updated conda build.sh and CMake configurationflowchart TD
Start([Start build.sh]) --> DetectOS
DetectOS["Check uname"] -->|Darwin| SetExtra["Set EXTRA_CMAKE_ARGS = -DCMAKE_OSX_DEPLOYMENT_TARGET=10.13"]
DetectOS -->|Other| ClearExtra["Set EXTRA_CMAKE_ARGS = empty"]
SetExtra --> Configure
ClearExtra --> Configure
Configure["Run cmake -G Ninja with:\n CMAKE_BUILD_TYPE=Release\n CMAKE_PREFIX_PATH=$PREFIX\n CMAKE_INSTALL_PREFIX=$PREFIX\n Python3_FIND_STRATEGY=LOCATION\n Python3_FIND_FRAMEWORK=NEVER\n SWIG_HIDE_WARNINGS=ON\n PYTHONOCC_MESHDS_NUMPY=ON\n EXTRA_CMAKE_ARGS"] --> Build
Build["Run ninja"] --> Install
Install["Run ninja install"] --> End([End build.sh])
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- In CMakeLists.txt, the new
execute_processusessys.prefixinstead of${CMAKE_INSTALL_PREFIX}as the base forrelpath, which changes the semantics from the previous distutils-based code and may produce incorrect install paths whenCMAKE_INSTALL_PREFIXdiffers from the Python prefix. - In
conda-build.yml, the build environment is now always created withpython=3.12even for 3.13/3.14 builds, whileconda-buildis invoked with--pythonset to the requested version; consider aligning the environment Python version withpy_maj/py_minunless there is a specific reason to decouple them. - The new Azure pipeline job templates have minor inconsistencies (double spaces in
- template: conda-build.ymland job names likemacOS_12_python313usingvmImage: 'macOS-latest'which is no longer 12); cleaning these up will make the configuration clearer and less confusing.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- In CMakeLists.txt, the new `execute_process` uses `sys.prefix` instead of `${CMAKE_INSTALL_PREFIX}` as the base for `relpath`, which changes the semantics from the previous distutils-based code and may produce incorrect install paths when `CMAKE_INSTALL_PREFIX` differs from the Python prefix.
- In `conda-build.yml`, the build environment is now always created with `python=3.12` even for 3.13/3.14 builds, while `conda-build` is invoked with `--python` set to the requested version; consider aligning the environment Python version with `py_maj/py_min` unless there is a specific reason to decouple them.
- The new Azure pipeline job templates have minor inconsistencies (double spaces in `- template: conda-build.yml` and job names like `macOS_12_python313` using `vmImage: 'macOS-latest'` which is no longer 12); cleaning these up will make the configuration clearer and less confusing.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by Sourcery
Add CI and conda-build support for Python 3.13 and 3.14 across all platforms and update build configuration for modern Python and toolchain compatibility.
New Features:
Enhancements:
Build:
CI:
Tests: