Now replacing comments with harmless dummy comments before processing…#9
Open
smarie wants to merge 2 commits intotqdm:masterfrom
Open
Now replacing comments with harmless dummy comments before processing…#9smarie wants to merge 2 commits intotqdm:masterfrom
smarie wants to merge 2 commits intotqdm:masterfrom
Conversation
… so as to fix bug when they contain reserved expressions. Fixes tqdm#8
1 similar comment
Member
|
the problem with this is: test:
echo 'hash#es' |
Codecov Report
@@ Coverage Diff @@
## master #9 +/- ##
==========================================
+ Coverage 94.06% 94.16% +0.09%
==========================================
Files 6 6
Lines 118 120 +2
Branches 25 26 +1
==========================================
+ Hits 111 113 +2
Misses 4 4
Partials 3 3 |
Author
|
I see. That might be a little trickier to do then, as of now I have no elegant suggestion to cover this case, apart from explicitly taking into account each possible quote character |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… so as to fix bug when they contain reserved expressions. Fixes #8