Change Petting rules to allow petting all friendly creatures

[CCF100]

I wanted to be able to pet all of the friendly mobs, so I wrote this PR lol

(I only updated the English text because I don't know those other languages)

[what-the-diff]

PR Summary

• Enhancement in Friendly Entity Recognition
  Updated the way friendly entities are detected. The existing method involved checking for specific types such as 'Wolf' and 'Cat'. We've improved this by having the system recognize any entity that falls under the category of being 'friendly'.

• Variable Names Adjusted for Understanding
  The variable previously named pet is now changed to entityToBeTargetted. This offers improved clarity when others review or work with the code, demonstrating exactly what the variable signifies.

• Optimized Height Difference Calculation
  The way we calculate height difference has been simplified. This change has been applied to the recently renamed variable entityToBeTargetted, optimizing this portion of the system.

• Preserved Code for Position Difference
  The existing code for calculating the position difference, posDif, remains untouched. This could indicate the part is still under development or future changes are expected.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[tr7zw]

Huh, wouldn't expect entHit.getEntity().getType().getCategory().isFriendly() to work in 1.16.5, gonna let the build run for all versions. Which EntityTypes are "friendly"? Does that also add animals like pigs, or just some like Parrots?

[tr7zw]

Apparently, everything except monsters are "friendly". I think this needs some refinement so stuff like boats/leashes/armorstands/villagers/minecarts/windcharge/itemframe etc don't end up being pettable 😅.

[CCF100]

Apparently, everything except monsters are "friendly". I think this needs some refinement so stuff like boats/leashes/armorstands/villagers/minecarts/windcharge/itemframe etc don't end up being pettable 😅.

Yeah, as is, even XP orbs are pettable, which is quite funny...

[NoahRoopull]

I'm no expert, and this might count as a necropost or something, but couldn't you use:

if (entHit != null && (entHit.getEntity() instanceof TameableAnimal))

to target anything that can be tamed? That would cover most other mods (Pet Cemetery's zombie/skeleton variants, Critters and Companions, etc.) as long as they extend TameableAnimal or something tameable from vanilla.

Of course, it wouldn't cover pigs, cows, sheep, etc., so if that's the goal, then I can be safely ignored, but I'd definitely like to see the petting animation work on more mobs.

[tr7zw]

I think combining that with a bigger rewrite would be better, that also keeps in mind the size of the animal. Especially when also looking at modded entities.