Skip to content

feat: enhance button styling with light variant and conditional color…#237

Merged
mikannkann merged 1 commit into
mainfrom
feature/229-improve-darkmode
Dec 21, 2025
Merged

feat: enhance button styling with light variant and conditional color…#237
mikannkann merged 1 commit into
mainfrom
feature/229-improve-darkmode

Conversation

@mikannkann

@mikannkann mikannkann commented Dec 21, 2025

Copy link
Copy Markdown
Collaborator

…s in transaction item and edit project modal


Closes #229

…s in transaction item and edit project modal
Copilot AI review requested due to automatic review settings December 21, 2025 10:05
@mikannkann mikannkann enabled auto-merge December 21, 2025 10:05
@github-actions github-actions Bot added type/enhancement 新機能の追加や既存機能の改善 area/client フロントエンド関連 labels Dec 21, 2025
@mikannkann mikannkann merged commit 1fffed0 into main Dec 21, 2025
8 checks passed
@mikannkann mikannkann deleted the feature/229-improve-darkmode branch December 21, 2025 10:06

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR enhances button styling by introducing a "light" variant to buttons in the EditProjectModal and adds conditional color styling to the transaction amount display in TransactionItem.

  • Adds "light" variant to all action buttons (delete and add buttons) in EditProjectModal for a more subtle appearance
  • Changes button colors from "green.5" to "green" to use standard Mantine theme colors
  • Introduces conditional gray coloring for transaction amounts when direction is "both"

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
src/components/TransactionItem.tsx Adds conditional gray color to PAmount component when transaction direction is "both"
src/components/EditProjectModal.tsx Updates button styling to use "light" variant and standardizes green color from "green.5" to "green" for consistency

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

)}
leadingIcon
coloring={direction !== "both"}
c={direction === "both" ? "#C9C9C9" : undefined}

Copilot AI Dec 21, 2025

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The hardcoded hex color value "#C9C9C9" is inconsistent with the project's color usage patterns. The codebase consistently uses Mantine's theme color tokens (e.g., "dimmed", "blue", "gray.7") rather than hardcoded hex values. Consider using a theme color like "gray" or "dimmed" instead for better maintainability and theme consistency.

Suggested change
c={direction === "both" ? "#C9C9C9" : undefined}
c={direction === "both" ? "dimmed" : undefined}

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/client フロントエンド関連 type/enhancement 新機能の追加や既存機能の改善

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Enhancement] ダークモードの改善

2 participants