バーコードモーダルの選択/ボタンでcomponents/UIを利用する#993
Open
nokhnaton wants to merge 7 commits into
Open
Conversation
ryoha000
reviewed
May 14, 2022
Contributor
Author
|
v-modelってstringしか受け付けないってことでいいのでしょうか?ItemsPageのSortTypeも基本はstringで特定の値だけしか受け付けないように設定してあるものって認識で大丈夫でしょうか? |
Member
|
昨日はやる気が出なかったので返信できませんでした。ごめんなさい
これは違くて受け取るコンポーネントの 部分ですね |
ryoha000
reviewed
May 16, 2022
Contributor
Author
|
直しました! |
ryoha000
reviewed
May 19, 2022
| const toastStore = useToast() | ||
|
|
||
| const codeReader = new BrowserBarcodeReader() | ||
| const inputs = ref<VideoInputDevice[]>([]) |
| const initialize = async () => { | ||
| try { | ||
| const videoInputDevices = await codeReader.getVideoInputDevices() | ||
| inputs.value = videoInputDevices |
| const inputs = ref<VideoInputDevice[]>([]) | ||
| const selectInput = ref<VideoInputDevice>() | ||
| const videoEle = shallowRef<HTMLVideoElement>() | ||
| const deviceOptions = ref<DeviceOption[]>([]) |
Member
There was a problem hiding this comment.
Suggested change
| const deviceOptions = ref<DeviceOption[]>([]) | |
| const deviceOptions = computed<DeviceOption[]>(() => inputs.map(v => ({ | |
| key: v?.deviceId ?? '', | |
| label: v?.label ?? 'no device name' | |
| }))) |
かな?
computedを使うと更新のし忘れがなくなるからこうしたいです
現状VideoInputDevice[]はinitializeでしか更新されてませんが今後ほかのところで更新することになるかもしれないので
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
セレクターの初期値を設定する部分がどうもうまくできてないようで、何も表示されません。他は見た目はちゃんと動いてると思います。