Skip to content

style(langchain): format codebase and verify ToolNode agent creation … #4368

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ManyaS-Git wants to merge 1 commit into
base: main
Choose a base branch
from
Open

style(langchain): format codebase and verify ToolNode agent creation … #4368

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
165 changes: 81 additions & 84 deletions ...entelemetry-instrumentation-langchain/opentelemetry/instrumentation/langchain/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@

logger = logging.getLogger(__name__)

_instruments = ("langchain-core > 0.1.0", )
_instruments = ("langchain-core > 0.1.0",)


class LangchainInstrumentor(BaseInstrumentor):
Expand Down Expand Up @@ -111,18 +111,15 @@ def _instrument(self, **kwargs):

if not Config.use_legacy_attributes:
logger_provider = kwargs.get("logger_provider")
Config.event_logger = get_logger(
__name__, __version__, logger_provider=logger_provider
)
Config.event_logger = get_logger(__name__, __version__, logger_provider=logger_provider)

traceloopCallbackHandler = TraceloopCallbackHandler(
tracer, duration_histogram, token_histogram
)
traceloopCallbackHandler = TraceloopCallbackHandler(tracer, duration_histogram, token_histogram)
wrap_function_wrapper(
"langchain_core.callbacks",
"BaseCallbackManager.__init__",
_BaseCallbackManagerInitWrapper(traceloopCallbackHandler,
),
_BaseCallbackManagerInitWrapper(
traceloopCallbackHandler,
),
)

# Wrap LangGraph components if available
Expand All @@ -137,67 +134,67 @@ def _wrap_openai_functions_for_tracing(self, traceloopCallbackHandler):
if is_package_available("langchain_community"):
# Wrap langchain_community.llms.openai.BaseOpenAI
wrap_function_wrapper(
"langchain_community.llms.openai",
"BaseOpenAI._generate",
openai_tracing_wrapper,
)
"langchain_community.llms.openai",
"BaseOpenAI._generate",
openai_tracing_wrapper,
)

wrap_function_wrapper(
"langchain_community.llms.openai",
"BaseOpenAI._agenerate",
openai_tracing_wrapper,
)
"langchain_community.llms.openai",
"BaseOpenAI._agenerate",
openai_tracing_wrapper,
)

wrap_function_wrapper(
"langchain_community.llms.openai",
"BaseOpenAI._stream",
openai_tracing_wrapper,
)
"langchain_community.llms.openai",
"BaseOpenAI._stream",
openai_tracing_wrapper,
)

wrap_function_wrapper(
"langchain_community.llms.openai",
"BaseOpenAI._astream",
openai_tracing_wrapper,
)
"langchain_community.llms.openai",
"BaseOpenAI._astream",
openai_tracing_wrapper,
)

if is_package_available("langchain_openai"):
# Wrap langchain_openai.llms.base.BaseOpenAI
wrap_function_wrapper(
"langchain_openai.llms.base",
"BaseOpenAI._generate",
openai_tracing_wrapper,
)
"langchain_openai.llms.base",
"BaseOpenAI._generate",
openai_tracing_wrapper,
)

wrap_function_wrapper(
"langchain_openai.llms.base",
"BaseOpenAI._agenerate",
openai_tracing_wrapper,
)
"langchain_openai.llms.base",
"BaseOpenAI._agenerate",
openai_tracing_wrapper,
)

wrap_function_wrapper(
"langchain_openai.llms.base",
"BaseOpenAI._stream",
openai_tracing_wrapper,
)
"langchain_openai.llms.base",
"BaseOpenAI._stream",
openai_tracing_wrapper,
)

wrap_function_wrapper(
"langchain_openai.llms.base",
"BaseOpenAI._astream",
openai_tracing_wrapper,
)
"langchain_openai.llms.base",
"BaseOpenAI._astream",
openai_tracing_wrapper,
)

# langchain_openai.chat_models.base.BaseOpenAI
wrap_function_wrapper(
"langchain_openai.chat_models.base",
"BaseChatOpenAI._generate",
openai_tracing_wrapper,
)
"langchain_openai.chat_models.base",
"BaseChatOpenAI._generate",
openai_tracing_wrapper,
)

wrap_function_wrapper(
"langchain_openai.chat_models.base",
"BaseChatOpenAI._agenerate",
openai_tracing_wrapper,
)
"langchain_openai.chat_models.base",
"BaseChatOpenAI._agenerate",
openai_tracing_wrapper,
)

# Doesn't work :(
# wrap_function_wrapper(
Expand All @@ -217,27 +214,32 @@ def _wrap_langgraph_components(self, tracer):
if is_package_available("langgraph"):
try:
wrap_function_wrapper(
"langgraph.pregel",
"Pregel.stream",
create_graph_invocation_wrapper(tracer, is_async=False,
),
"langgraph.pregel",
"Pregel.stream",
create_graph_invocation_wrapper(
tracer,
is_async=False,
),
)
wrap_function_wrapper(
"langgraph.pregel",
"Pregel.astream",
create_graph_invocation_wrapper(tracer, is_async=True,
),
"langgraph.pregel",
"Pregel.astream",
create_graph_invocation_wrapper(
tracer,
is_async=True,
),
)
except Exception as e:
logger.debug("Failed to wrap Pregel methods: %s", e)

# Wrap Command.__init__ to capture routing commands
try:
wrap_function_wrapper(
"langgraph.types",
"Command.__init__",
create_command_init_wrapper(tracer,
),
"langgraph.types",
"Command.__init__",
create_command_init_wrapper(
tracer,
),
)
except Exception as e:
logger.debug("Failed to wrap Command.__init__: %s", e)
Expand All @@ -257,19 +259,19 @@ def _wrap_agent_factories(self, tracer):
# Patch the actual module where the function is defined
try:
wrap_function_wrapper(
"langgraph.prebuilt.chat_agent_executor",
"create_react_agent",
langgraph_agent_wrapper,
)
"langgraph.prebuilt.chat_agent_executor",
"create_react_agent",
langgraph_agent_wrapper,
)
except Exception as e:
logger.debug("Failed to wrap langgraph.prebuilt.chat_agent_executor.create_react_agent: %s", e)
# Also patch the re-export location for imports from langgraph.prebuilt
try:
wrap_function_wrapper(
"langgraph.prebuilt",
"create_react_agent",
langgraph_agent_wrapper,
)
"langgraph.prebuilt",
"create_react_agent",
langgraph_agent_wrapper,
)
except Exception as e:
logger.debug("Failed to wrap langgraph.prebuilt.create_react_agent: %s", e)

Expand All @@ -279,19 +281,19 @@ def _wrap_agent_factories(self, tracer):
# Patch the actual module where the function is defined
try:
wrap_function_wrapper(
"langchain.agents.factory",
"create_agent",
agent_wrapper,
)
"langchain.agents.factory",
"create_agent",
agent_wrapper,
)
except Exception as e:
logger.debug("Failed to wrap langchain.agents.factory.create_agent: %s", e)
# Also patch the re-export location for imports from langchain.agents
try:
wrap_function_wrapper(
"langchain.agents",
"create_agent",
agent_wrapper,
)
"langchain.agents",
"create_agent",
agent_wrapper,
)
except Exception as e:
logger.debug("Failed to wrap langchain.agents.create_agent: %s", e)

Expand Down Expand Up @@ -437,17 +439,12 @@ def __call__(
TraceContextTextMapPropagator().inject(extra_headers, context=ctx)
kwargs["extra_headers"] = extra_headers
else:
logger.debug(
"No span found for run_id %s, skipping header injection",
run_id
)
logger.debug("No span found for run_id %s, skipping header injection", run_id)

# In legacy chains like LLMChain, suppressing model instrumentations
# within create_llm_span doesn't work, so this should helps as a fallback
try:
context_api.attach(
context_api.set_value(SUPPRESS_LANGUAGE_MODEL_INSTRUMENTATION_KEY, True)
)
context_api.attach(context_api.set_value(SUPPRESS_LANGUAGE_MODEL_INSTRUMENTATION_KEY, True))
except Exception:
# If context setting fails, continue without suppression
# This is not critical for core functionality
Expand Down
Loading