Skip to content

fix(anthropic): stop double-counting output tokens on streamed messages #4377

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
arthi-arumugam-git wants to merge 1 commit into
base: main
Choose a base branch
from
+7 −7
Open

fix(anthropic): stop double-counting output tokens on streamed messages #4377

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 6 additions & 7 deletions ...ntelemetry-instrumentation-anthropic/opentelemetry/instrumentation/anthropic/streaming.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,13 +62,12 @@ def _process_response_item(item, complete_response):
event["finish_reason"] = item.delta.stop_reason
if item.usage:
if "usage" in complete_response:
item_output_tokens = dict(item.usage).get("output_tokens", 0)
existing_output_tokens = complete_response["usage"].get(
"output_tokens", 0
)
complete_response["usage"]["output_tokens"] = (
item_output_tokens + existing_output_tokens
)
# message_delta carries the running total for the whole message,
# not an increment, so it replaces the partial count reported by
# message_start rather than adding to it.
item_output_tokens = dict(item.usage).get("output_tokens")
if item_output_tokens is not None:
complete_response["usage"]["output_tokens"] = item_output_tokens
else:
complete_response["usage"] = dict(item.usage)

Expand Down
1 change: 1 addition & 0 deletions packages/opentelemetry-instrumentation-anthropic/tests/test_messages.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -680,6 +680,7 @@ def test_anthropic_message_streaming_legacy(
assert text_parts[0]["content"] == response_content
assert output_messages[-1]["role"] == "assistant"
assert anthropic_span.attributes[GenAIAttributes.GEN_AI_USAGE_INPUT_TOKENS] == 17
assert anthropic_span.attributes[GenAIAttributes.GEN_AI_USAGE_OUTPUT_TOKENS] == 171
assert (
anthropic_span.attributes[GenAIAttributes.GEN_AI_USAGE_OUTPUT_TOKENS]
+ anthropic_span.attributes[GenAIAttributes.GEN_AI_USAGE_INPUT_TOKENS]
Expand Down