fix(sdk): restore agent context after decorator exits#4379
Open
yaodong-shen wants to merge 1 commit into
Open
Conversation
Scope the agent name to the span context token so cleanup restores the prior OpenTelemetry context. Add regressions for standalone work and sibling tasks within a workflow.\n\nFixes traceloop#4378
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughThe SDK now scopes agent names through the span context during agent span creation and records them on agent spans. Regression tests verify that completed agents do not leak metadata or parentage into subsequent tasks while enclosing workflow context is restored. ChangesAgent context isolation
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
gen_ai.agent.nameto the@agentspan context tokenRoot cause
_setup_span()attached the agent name before attaching the span context, then discarded that first token. Cleanup detached only the span token, restoring a context that still contained the completed agent name. Subsequent spans therefore inherited stalegen_ai.agent.namemetadata.Validation
npx nx run traceloop-sdk:lintnpx nx run traceloop-sdk:type-checknpx nx run traceloop-sdk:test— 417 passedFixes #4378
Checklist
feat(instrumentation): ...orfix(instrumentation): ....Summary by CodeRabbit
Bug Fixes
Tests