[pull] master from golang:master#128
Merged
Merged
Conversation
Fixes #80360. [git-generate] updatestd -goroot=$(pwd) -branch=internal-branch.go1.27-vendor Change-Id: I0c866cf97f621b8399c8982de4ca568be9043eed Reviewed-on: https://go-review.googlesource.com/c/go/+/799620 Auto-Submit: Dmitri Shuralyov <dmitshur@golang.org> Reviewed-by: Dmitri Shuralyov <dmitshur@google.com> Reviewed-by: Sean Liao <sean@liao.dev> Reviewed-by: David Chase <drchase@google.com> LUCI-TryBot-Result: golang-scoped@luci-project-accounts.iam.gserviceaccount.com <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Using reflect.Value.Pointer to compare function values for equality is problematic. For closures, the same code pointer does not necessarily mean the functions have the same behavior, as the captured variables may have different values, which are not included in the comparison. Change-Id: Ib95912cce52d3863f8fe77d874ffa2f277dbd0b6 Reviewed-on: https://go-review.googlesource.com/c/go/+/788441 Reviewed-by: Austin Clements <austin@google.com> LUCI-TryBot-Result: golang-scoped@luci-project-accounts.iam.gserviceaccount.com <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
It's late in the cycle, let's just disable this new pass and try again for 1.28. Update #80102 Change-Id: Idcda2814e22f017999813a52b06013df3735bf18 Reviewed-on: https://go-review.googlesource.com/c/go/+/799700 Reviewed-by: Chencheng Jiang <dorbmons@gmail.com> LUCI-TryBot-Result: golang-scoped@luci-project-accounts.iam.gserviceaccount.com <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Reviewed-by: Jorropo <jorropo.pgm@gmail.com> Reviewed-by: David Chase <drchase@google.com> Reviewed-by: Keith Randall <khr@google.com> Reviewed-by: Daniel Morsing <daniel.morsing@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )