[pull] master from golang:master#129
Merged
Merged
Conversation
Nextafter and Nextafter32 have distinct behavior when the starting value is a signed zero, which the special-case lists did not mention: towards the oppositely-signed zero the result keeps the starting sign, and towards any nonzero y the result is the smallest subnormal with the sign of y. Document these cases; the behavior is unchanged. Fixes #42613 Change-Id: I8c6f0f3fc821d285d6870e76edf72391b124d350 GitHub-Last-Rev: 34eb6cc GitHub-Pull-Request: #80359 Reviewed-on: https://go-review.googlesource.com/c/go/+/799400 Reviewed-by: Keith Randall <khr@google.com> LUCI-TryBot-Result: golang-scoped@luci-project-accounts.iam.gserviceaccount.com <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Reviewed-by: Michael Pratt <mpratt@google.com> Auto-Submit: Keith Randall <khr@golang.org> Reviewed-by: Keith Randall <khr@golang.org>
ABIConfig.Copy became a no-op after the register cache was removed. Its only caller still treated the returned configuration as a fresh copy, even though Copy simply returned its receiver. Remove Copy, use the shared ABI0 configuration directly, and update the stale comments describing copied ABI configurations. Change-Id: I23e51c197811ec409473737b570232e459ec79b4 Reviewed-on: https://go-review.googlesource.com/c/go/+/796120 Auto-Submit: Keith Randall <khr@golang.org> Reviewed-by: Keith Randall <khr@golang.org> Reviewed-by: Michael Pratt <mpratt@google.com> Reviewed-by: Keith Randall <khr@google.com> LUCI-TryBot-Result: golang-scoped@luci-project-accounts.iam.gserviceaccount.com <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
The TODO asked whether a zero-byte Read should wait for readability. CL 22031 proposed that behavior and was abandoned. Blocking would change the behavior of existing callers, and the netpoller's edge-triggered notifications alone cannot detect data that is already buffered. Replace the stale TODO with the outcome. Updates #15735 Change-Id: Iad2087b123db58e6bf531f81f8411f363a5b2a1a GitHub-Last-Rev: 0c3e22b GitHub-Pull-Request: #80244 Reviewed-on: https://go-review.googlesource.com/c/go/+/796620 LUCI-TryBot-Result: golang-scoped@luci-project-accounts.iam.gserviceaccount.com <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Reviewed-by: Michael Pratt <mpratt@google.com> Auto-Submit: Ian Lance Taylor <iant@golang.org> Reviewed-by: Ian Lance Taylor <iant@golang.org> Reviewed-by: David Chase <drchase@google.com>
Pid is an exported field but had no doc comment. Fixes #36726 Change-Id: I4eb213c004f7bcfcab758a56554b489ce6eb7305 GitHub-Last-Rev: d00a492 GitHub-Pull-Request: #80337 Reviewed-on: https://go-review.googlesource.com/c/go/+/799062 Reviewed-by: Ian Lance Taylor <iant@golang.org> Reviewed-by: Michael Pratt <mpratt@google.com> Auto-Submit: Michael Pratt <mpratt@google.com> Reviewed-by: David Chase <drchase@google.com> LUCI-TryBot-Result: golang-scoped@luci-project-accounts.iam.gserviceaccount.com <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
ReadFile opens the file with Open and reads it with File.Read, both of which return errors of type *PathError. Document this on ReadFile, as is already done for Open and other functions in the package, so callers know they can inspect the error (for example with errors.As) without reading the source. Fixes #80111 Change-Id: Ifb4b10127c2cf8daae661d136d5d9edbc4613e8a Reviewed-on: https://go-review.googlesource.com/c/go/+/795160 Auto-Submit: Sean Liao <sean@liao.dev> Reviewed-by: David Chase <drchase@google.com> LUCI-TryBot-Result: golang-scoped@luci-project-accounts.iam.gserviceaccount.com <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Reviewed-by: Michael Pratt <mpratt@google.com> Reviewed-by: Maciej Szeptuch <mszeptuch@gmail.com> Reviewed-by: Sean Liao <sean@liao.dev>
Funcs was documented only as "It must be called before the template is parsed", which suggests it cannot be called afterward. In fact a function used in the template must be registered before parsing, but Funcs may be called again later (including after Clone) to replace a function of the same name, and the replacement takes effect when the template is executed. Fixes #34680 Change-Id: I819bc3bcb7452b2fd0bd08d2e97e737493944029 GitHub-Last-Rev: a521e2c GitHub-Pull-Request: #80356 Reviewed-on: https://go-review.googlesource.com/c/go/+/799340 Reviewed-by: Sean Liao <sean@liao.dev> Reviewed-by: David Chase <drchase@google.com> Auto-Submit: Sean Liao <sean@liao.dev> LUCI-TryBot-Result: golang-scoped@luci-project-accounts.iam.gserviceaccount.com <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Reviewed-by: Michael Pratt <mpratt@google.com> Reviewed-by: Rob Pike <r@golang.org>
Fixes #43064 Change-Id: Ie693c05563e5694b8ba57eebd459d3c0a2d2a4d6 GitHub-Last-Rev: 91709d7 GitHub-Pull-Request: #80336 Reviewed-on: https://go-review.googlesource.com/c/go/+/799061 Auto-Submit: Sean Liao <sean@liao.dev> Reviewed-by: Sean Liao <sean@liao.dev> Reviewed-by: Michael Pratt <mpratt@google.com> Reviewed-by: David Chase <drchase@google.com> LUCI-TryBot-Result: golang-scoped@luci-project-accounts.iam.gserviceaccount.com <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
On arm64, the contents of R30 are saved in this 16-byte frame (when doing async preemption). But we don't scan that little frame. So any pointer that was in R30 will not get scanned. So the object it points to may get collected prematurely. Fixes #80188 The test here is pretty quick (~1/3 sec) and fails ~50% of the time. Change-Id: I46a7a6a25fabeb4f15dca96ee6fdd5e99d4c6323 Reviewed-on: https://go-review.googlesource.com/c/go/+/797521 Reviewed-by: Cherry Mui <cherryyz@google.com> Reviewed-by: Keith Randall <khr@google.com> LUCI-TryBot-Result: golang-scoped@luci-project-accounts.iam.gserviceaccount.com <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Auto-Submit: Keith Randall <khr@golang.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )