docs(spec): add key rotation security audit draft for Issue #3#17
Merged
chrishooooo-netizen merged 2 commits intoMay 6, 2026
Merged
Conversation
chrishooooo-netizen
approved these changes
May 6, 2026
Contributor
chrishooooo-netizen
left a comment
There was a problem hiding this comment.
Approving — thank you for the structured audit, this is exactly the level of rigor the spec needed. The P0/P1/P2 split is clean and implementable, and the suggested spec patch in §8 is a good starting point for v1.3 work.
Particularly valuable:
- The compromised-key vs routine-rotation distinction (§4)
- Explicit
pending/active/retired/revokedlifecycle states (P0) - Registry-signed checkpoint idea (P1) for federation consistency
- The freshness/version downgrade prevention (P1)
I will track the P0 items as candidates for v1.3 and the P1 federation/freshness items for the broader v1.3/v2.0 roadmap. The open questions in §7 are good agenda items for future community discussion.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a structured security audit draft for
did:trailkey rotation semantics.Covers
Why
Issue #3 asks for a security review of key rotation, revocation timing, recovery scenarios, MITM during DID resolution, registry compromise, and replay attacks with stale DID Documents.
Related to #3