feat: Configure AI usage counter by kofimokome · Pull Request #11 · trakli/cloud

kofimokome · 2026-06-28T16:52:32Z

Fixes #7

Depends on #10

# Conflicts: # src/CloudServiceProvider.php

sourceant · 2026-06-28T16:53:08Z

Code Review Summary

Introduces AI usage tracking and Stripe billing integration using Laravel Cashier.

🚀 Key Improvements

Implementation of CloudEntitlements for AI token management.
Standardized Stripe Checkout flow in CloudController.

💡 Minor Suggestions

Replace hardcoded 'price_id' strings in cloudplans.php with environment variables.
Add sanitization for the region parameter in API requests.

🚨 Critical Issues

Race conditions in AiUsageCounter updates during concurrent token consumption.
Hardcoded placeholder IDs in the configuration file will break production environments.

sourceant

Review complete. See the overview comment for a summary.

sourceant · 2026-06-28T16:53:09Z

        'us' => [
            'name' => 'United States',
            'currency' => 'USD',
+            'monthly_price_id'=>'plan_id', // from stripe


The keys 'monthly_price_id' and 'yearly_price_id' should be consistent across all regions and should preferably use ENV variables instead of hardcoded 'plan_id' or 'price_id' placeholders to ensure security and flexibility across environments.

Suggested change

'monthly_price_id'=>'plan_id', // from stripe

'monthly_price_id' => env('STRIPE_MONTHLY_PRICE_ID_US'),

'monthly_price' => (float) env('CLOUD_PLAN_MONTHLY_PRICE_US', 5.00),

'yearly_price' => (float) env('CLOUD_PLAN_YEARLY_PRICE_US', 50.00),

'yearly_price_id' => env('STRIPE_YEARLY_PRICE_ID_US'),

sourceant · 2026-06-28T16:53:09Z

+    /**
+     * Find the chat message ID from the backtrace to key the idempotent increment.
+     */
+    private function getCurrentChatMessageId(): ?int


Using debug_backtrace to implement idempotency is highly discouraged. It is slow and relies on internal call structures that may change. Pass the message ID or an idempotency token explicitly to the consume method instead.

Suggested change

private function getCurrentChatMessageId(): ?int

// Recommended: Pass the unique identifier directly to the consume method.

// If that is not possible, ensure ProcessChatMessageJob is always present in the stack.

sourceant

Review complete. See the overview comment for a summary.

sourceant · 2026-07-06T20:12:28Z

+        $counter = AiUsageCounter::where('owner_id', $owner->id)
+            ->where('owner_type', get_class($owner))


This update logic is prone to race conditions (Lost Updates). If two messages are processed simultaneously for the same user, one increment might overwrite the other. Use an atomic updateOrCreate with a DB raw increment or a raw SQL query.

Suggested change

$counter = AiUsageCounter::where('owner_id', $owner->id)

->where('owner_type', get_class($owner))

AiUsageCounter::updateOrCreate(

[

'owner_id' => $owner->id,

'owner_type' => get_class($owner),

'period_start' => $periodStart,

],

['tokens_used' => DB::raw("tokens_used + $amount")]

);

sourceant · 2026-07-06T20:12:29Z

+    {
+        Schema::create('subscriptions', function (Blueprint $table) {
+            $table->id();
+            $table->foreignId('user_id')->constrained('billing_customers')->cascadeOnDelete();


The foreign key references 'billing_customers' but the column is named 'user_id'. This is confusing because 'user_id' usually points to the 'users' table. In Cashier, the billable model (BillingCustomer) has its own ID. Ensure consistency in naming.

Suggested change

$table->foreignId('user_id')->constrained('billing_customers')->cascadeOnDelete();

$table->foreignId('billing_customer_id')->constrained('billing_customers')->cascadeOnDelete();

sourceant

Review complete. See the overview comment for a summary.

sourceant · 2026-07-06T20:18:54Z

+    /**
+     * Get the user that owns this usage counter.
+     */
+    public function user(): BelongsTo


The model uses morphs('owner') in the migration, but the relationship is hardcoded to User. Use a morphTo relation to maintain consistency with the DB schema.

Suggested change

public function user(): BelongsTo

public function owner(): \Illuminate\Database\Eloquent\Relations\MorphTo

{

return $this->morphTo();

}

sourceant

Review complete. See the overview comment for a summary.

sourceant · 2026-07-06T20:21:59Z

+        $region = $request->input('region', 'us');
+        $regionData = $config['regions'][$region];
+
+        /** @var \Trakli\Cloud\Models\BillingCustomer $billingCustomer */


Retrieving the BillingCustomer via firstOrCreate without checking if the user actually exists or is active can lead to orphaned billing records. Additionally, 'user_id' mapping should ensure it's pointing to the correct ID type.

Suggested change

/** @var \Trakli\Cloud\Models\BillingCustomer $billingCustomer */

$billingCustomer = \Trakli\Cloud\Models\BillingCustomer::firstOrCreate(

['user_id' => $user->getAuthIdentifier()],

['trial_ends_at' => null]

);

nfebe

This looks good but since we have multiple projects that the question of tokens will come up. I built and publish a package that will simplify things there is already a task to implement it in the core and it may remove the need for one table you have here.

See: https://github.com/whilesmartphp/eloquent-agent-metrics

kofimokome added 3 commits June 26, 2026 23:58

feat: Configure Cashier

abff589

feat: Configure AI usage counter

0e28396

# Conflicts: # src/CloudServiceProvider.php

chore: Update Entitlements

6e27c7a

kofimokome marked this pull request as draft June 28, 2026 16:52

sourceant Bot reviewed Jun 28, 2026

View reviewed changes

kofimokome marked this pull request as ready for review July 6, 2026 20:12

sourceant Bot suggested changes Jul 6, 2026

View reviewed changes

kofimokome force-pushed the feat/ai-allowance branch from 35627ef to ea97334 Compare July 6, 2026 20:18

sourceant Bot reviewed Jul 6, 2026

View reviewed changes

feat: Make ai usage counter polymorphic

d97f1f4

kofimokome force-pushed the feat/ai-allowance branch from ea97334 to d97f1f4 Compare July 6, 2026 20:21

sourceant Bot suggested changes Jul 6, 2026

View reviewed changes

kofimokome requested a review from nfebe July 6, 2026 20:25

kofimokome mentioned this pull request Jul 6, 2026

feat: Add plan features and gating middleware #12

Open

nfebe reviewed Jul 7, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat: Configure AI usage counter#11

feat: Configure AI usage counter#11
kofimokome wants to merge 4 commits into
mainfrom
feat/ai-allowance

kofimokome commented Jun 28, 2026 •

edited

Loading

Uh oh!

sourceant Bot commented Jun 28, 2026 •

edited

Loading

Uh oh!

sourceant Bot left a comment

Uh oh!

sourceant Bot Jun 28, 2026

Uh oh!

sourceant Bot Jun 28, 2026

Uh oh!

sourceant Bot left a comment

Uh oh!

sourceant Bot Jul 6, 2026

Uh oh!

sourceant Bot Jul 6, 2026

Uh oh!

sourceant Bot left a comment

Uh oh!

sourceant Bot Jul 6, 2026

Uh oh!

sourceant Bot left a comment

Uh oh!

sourceant Bot Jul 6, 2026

Uh oh!

nfebe left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

-            'monthly_price_id'=>'plan_id', // from stripe
+            'monthly_price_id' => env('STRIPE_MONTHLY_PRICE_ID_US'),
+            'monthly_price' => (float) env('CLOUD_PLAN_MONTHLY_PRICE_US', 5.00),
+            'yearly_price' => (float) env('CLOUD_PLAN_YEARLY_PRICE_US', 50.00),
+            'yearly_price_id' => env('STRIPE_YEARLY_PRICE_ID_US'),

	private function getCurrentChatMessageId(): ?int
	// Recommended: Pass the unique identifier directly to the consume method.
	// If that is not possible, ensure ProcessChatMessageJob is always present in the stack.

		$counter = AiUsageCounter::where('owner_id', $owner->id)
		->where('owner_type', get_class($owner))

-        $counter = AiUsageCounter::where('owner_id', $owner->id)
-            ->where('owner_type', get_class($owner))
+        AiUsageCounter::updateOrCreate(
+            [
+                'owner_id' => $owner->id,
+                'owner_type' => get_class($owner),
+                'period_start' => $periodStart,
+            ],
+            ['tokens_used' => DB::raw("tokens_used + $amount")]
+        );

	$table->foreignId('user_id')->constrained('billing_customers')->cascadeOnDelete();
	$table->foreignId('billing_customer_id')->constrained('billing_customers')->cascadeOnDelete();

-    public function user(): BelongsTo
+    public function owner(): \Illuminate\Database\Eloquent\Relations\MorphTo
+    {
+        return $this->morphTo();
+    }

-        /** @var \Trakli\Cloud\Models\BillingCustomer $billingCustomer */
+        $billingCustomer = \Trakli\Cloud\Models\BillingCustomer::firstOrCreate(
+            ['user_id' => $user->getAuthIdentifier()],
+            ['trial_ends_at' => null]
+        );

Uh oh!

Conversation

kofimokome commented Jun 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sourceant Bot commented Jun 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Code Review Summary

🚀 Key Improvements

💡 Minor Suggestions

🚨 Critical Issues

Uh oh!

sourceant Bot left a comment

Choose a reason for hiding this comment

Uh oh!

sourceant Bot Jun 28, 2026

Choose a reason for hiding this comment

Uh oh!

sourceant Bot Jun 28, 2026

Choose a reason for hiding this comment

Uh oh!

sourceant Bot left a comment

Choose a reason for hiding this comment

Uh oh!

sourceant Bot Jul 6, 2026

Choose a reason for hiding this comment

Uh oh!

sourceant Bot Jul 6, 2026

Choose a reason for hiding this comment

Uh oh!

sourceant Bot left a comment

Choose a reason for hiding this comment

Uh oh!

sourceant Bot Jul 6, 2026

Choose a reason for hiding this comment

Uh oh!

sourceant Bot left a comment

Choose a reason for hiding this comment

Uh oh!

sourceant Bot Jul 6, 2026

Choose a reason for hiding this comment

Uh oh!

nfebe left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

kofimokome commented Jun 28, 2026 •

edited

Loading

sourceant Bot commented Jun 28, 2026 •

edited

Loading