feat: add rate-now rating and toast content#2328
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the user experience by refining the rating and toast notification components. It introduces more dynamic content for rating prompts, improves the visual presentation of empty states in the 'Where to Watch' section, and adds flexibility to the RateNow component to ensure consistent layout behavior across different parts of the application. Highlights
Ignored Files
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
|
|
Overall Grade |
Security Reliability Complexity Hygiene |
Code Review Summary
| Analyzer | Status | Updated (UTC) | Details |
|---|---|---|---|
| JavaScript | May 28, 2026 1:02p.m. | Review ↗ | |
| Code coverage | May 28, 2026 1:02p.m. | Review ↗ |
Important
AI Review is run only on demand for your team. We're only showing results of static analysis review right now. To trigger AI Review, comment @deepsourcebot review on this thread.
There was a problem hiding this comment.
Code Review
This pull request updates a subproject commit, modifies i18n metadata, and introduces a new WhereToWatchEmptyItem component for empty states in the Where to Watch section. It also enhances the Rate Now toast with randomized prompts and layout updates. Key feedback includes addressing SSR safety issues when accessing localStorage, moving hardcoded strings to the i18n system, and cleaning up the styles by removing redundant SCSS declarations, dead CSS, and duplicated global rules.
- RateNowContent: harden getNextPrompt against SSR (typeof window check) and corrupted localStorage values (NaN guard); migrate the 9 hardcoded rating prompts to i18n keys (text_rating_prompt_*). - WhereToWatchEmptyItem: surface the empty-state text via text_no_services_available i18n key, drop dead .trakt-link CSS, collapse the duplicate :first-child/:last-child rules into a single span selector. - WhereToWatchList: drop lang="scss" — no SCSS-specific features in use.
Summary
Tightens up the Rate Now toast and Where-to-Watch empty state with shared building blocks.
sections/toast/_internal/RateNowContent.svelte)RateNowcomponent (sections/summary/components/rating/RateNow.svelte)hideLabelprop so callers (like the toast) can render the stars without the helper label, while consuming pages keep the label.sections/lists/where-to-watch/_internal/WhereToWatchEmptyItem.svelte)WhereToWatchListandWhereToWatchDrawerwhen there are no streaming sources for the user's region.Test plan
deno task client:checkanddeno task client:testboth pass.