Drop support for Python 3.6#64
Merged
Samira-El merged 16 commits intotransferwise:masterfrom May 13, 2022
edgarrmondragon:drop-python-3.6
Merged
Drop support for Python 3.6#64Samira-El merged 16 commits intotransferwise:masterfrom edgarrmondragon:drop-python-3.6
Samira-El merged 16 commits intotransferwise:masterfrom
edgarrmondragon:drop-python-3.6
Conversation
`nose` is no longer maintained and last had a release on 2015. It's also not compatible with Python 3.10. `pytest` is able to run the same test suite without any changes.
edgarrmondragon
commented
May 5, 2022
Contributor
Author
|
@Samira-El this is ready for review, lmk what you think! |
Samira-El
reviewed
May 12, 2022
Collaborator
Samira-El
left a comment
There was a problem hiding this comment.
Thanks Edgar for the PR!
In general it lgtm, I left few comments.
Contributor
Author
|
@Samira-El thanks for the feedback. This is ready for another review :) |
Samira-El
approved these changes
May 13, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of change
python_requires.nosewithpytest.blackandisortconfigurations (not yet applied to any project files)..pre-commit-config.yaml.Manual QA steps
Use
pytest:I've used the GitHub CLI successfully with the command
gh workflow run -r drop-python-3.6. Example output: https://github.com/edgarrmondragon/pipelinewise-singer-python/actions/runs/2302679477Risks
Rollback steps
Closes #63