Skip to content

Drop support for Python 3.6#64

Merged
Samira-El merged 16 commits intotransferwise:masterfrom
edgarrmondragon:drop-python-3.6
May 13, 2022
Merged

Drop support for Python 3.6#64
Samira-El merged 16 commits intotransferwise:masterfrom
edgarrmondragon:drop-python-3.6

Conversation

@edgarrmondragon
Copy link
Copy Markdown
Contributor

@edgarrmondragon edgarrmondragon commented May 5, 2022

Description of change

  • Drop support for Python 3.6 using python_requires.
  • Replace nose with pytest.
  • Set up black and isort configurations (not yet applied to any project files).
  • Create .pre-commit-config.yaml.

Manual QA steps

Risks

  • Packages using this library and relying on Python 3.6 might face problems if they try to upgrade without similarly dropping support for 3.6.

Rollback steps

  • Revert this branch

Closes #63

@edgarrmondragon edgarrmondragon changed the title Drop python 3.6 Drop support for Python 3.6 May 5, 2022
Comment thread .github/workflows/main.yml
Comment thread .github/workflows/main.yml
Comment thread pyproject.toml
Comment thread .pre-commit-config.yaml
@edgarrmondragon edgarrmondragon marked this pull request as ready for review May 10, 2022 19:29
@edgarrmondragon
Copy link
Copy Markdown
Contributor Author

@Samira-El this is ready for review, lmk what you think!

Copy link
Copy Markdown
Collaborator

@Samira-El Samira-El left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Edgar for the PR!

In general it lgtm, I left few comments.

Comment thread setup.py Outdated
Comment thread .github/workflows/main.yml
Comment thread pyproject.toml Outdated
Comment thread pyproject.toml Outdated
@edgarrmondragon
Copy link
Copy Markdown
Contributor Author

@Samira-El thanks for the feedback. This is ready for another review :)

Copy link
Copy Markdown
Collaborator

@Samira-El Samira-El left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you :)

@Samira-El Samira-El merged commit a916726 into transferwise:master May 13, 2022
@edgarrmondragon edgarrmondragon deleted the drop-python-3.6 branch May 13, 2022 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Drop support for Python 3.6

2 participants