Skip to content
This repository was archived by the owner on Dec 1, 2025. It is now read-only.

Spring ID Metric Tag (PAYINP-3419)#97

Merged
mscott-tw merged 1 commit into
masterfrom
PAYINP-3419_meter_spring_id_tag
Aug 26, 2025
Merged

Spring ID Metric Tag (PAYINP-3419)#97
mscott-tw merged 1 commit into
masterfrom
PAYINP-3419_meter_spring_id_tag

Conversation

@mscott-tw

Copy link
Copy Markdown
Contributor

Context

Add the spring.id tag to the kafka client metrics, for created kafka producers, to avoid service startup warnings about registering meters with different tag keys on Spring Boot 3.4+.

As prior versions of Spring Boot don't seem to set the tag, this change can in turn cause these same warnings on versions older than 3.4. However, given those versions are now out of OSS support, this trade off seems acceptable.

This applies the same change we've made in tw-tasks and wise-kafka-producer.

Checklist

Copilot AI review requested due to automatic review settings August 25, 2025 10:20
@mscott-tw mscott-tw requested a review from a team as a code owner August 25, 2025 10:20
@platon-github-app-production

Copy link
Copy Markdown

Comment /request-review to automatically request reviews from the following teams:

You can also request review from a specific team by commenting /request-review team-name, or you can add a description with --notes "<message>"

💡 If you see something that doesn't look right, check the configuration guide.

@mscott-tw

Copy link
Copy Markdown
Contributor Author

/request-review

@platon-github-app-production

Copy link
Copy Markdown

Success 🎉 The review request was sent to the following teams:

If you see something that doesn't look right, follow this doc to improve our slack channel mapping. Thank you!

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Adds the spring.id tag to Kafka client metrics for Spring Boot 3.4+ compatibility to prevent service startup warnings about registering meters with different tag keys.

  • Extracts client ID creation into a variable for reuse in metrics tagging
  • Adds spring.id tag to KafkaClientMetrics constructor with the client ID value
  • Updates version from 0.35.0 to 0.36.0 and adds changelog entry

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

File Description
TkmsKafkaProducerProvider.java Extracts client ID generation and adds spring.id tag to Kafka metrics
gradle.properties Bumps version to 0.36.0
build.common.gradle Contains duplicate dependency resolution configuration
CHANGELOG.md Documents the spring.id tag addition for version 0.36.0

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment thread build.common.gradle Outdated
@mscott-tw mscott-tw force-pushed the PAYINP-3419_meter_spring_id_tag branch from b08bc33 to fb9d852 Compare August 25, 2025 10:21

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@normanma-tw normanma-tw left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change makes sense to me, one comment

Comment thread CHANGELOG.md Outdated
Add the `spring.id` tag to the kafka client metrics, for created kafka producers, to avoid service startup warnings about registering meters with different tag keys on Spring Boot 3.4+.

As prior versions of Spring Boot don't seem to set the tag, this change can in turn cause these same warnings on versions older than 3.4. However, given those versions are now out of OSS support, this trade off seems acceptable.

This applies the same change we've made in tw-tasks and wise-kafka-producer.
@mscott-tw mscott-tw force-pushed the PAYINP-3419_meter_spring_id_tag branch from fb9d852 to f1cbc2a Compare August 26, 2025 10:29
@mscott-tw mscott-tw merged commit 2d84f7f into master Aug 26, 2025
15 checks passed
@mscott-tw mscott-tw deleted the PAYINP-3419_meter_spring_id_tag branch August 26, 2025 10:36
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants