Spring ID Metric Tag (PAYINP-3419)#97
Conversation
|
Comment
You can also request review from a specific team by commenting 💡 If you see something that doesn't look right, check the configuration guide. |
|
/request-review |
|
Success 🎉 The review request was sent to the following teams:
If you see something that doesn't look right, follow this doc to improve our slack channel mapping. Thank you! |
There was a problem hiding this comment.
Pull Request Overview
Adds the spring.id tag to Kafka client metrics for Spring Boot 3.4+ compatibility to prevent service startup warnings about registering meters with different tag keys.
- Extracts client ID creation into a variable for reuse in metrics tagging
- Adds spring.id tag to KafkaClientMetrics constructor with the client ID value
- Updates version from 0.35.0 to 0.36.0 and adds changelog entry
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| TkmsKafkaProducerProvider.java | Extracts client ID generation and adds spring.id tag to Kafka metrics |
| gradle.properties | Bumps version to 0.36.0 |
| build.common.gradle | Contains duplicate dependency resolution configuration |
| CHANGELOG.md | Documents the spring.id tag addition for version 0.36.0 |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
b08bc33 to
fb9d852
Compare
normanma-tw
left a comment
There was a problem hiding this comment.
change makes sense to me, one comment
Add the `spring.id` tag to the kafka client metrics, for created kafka producers, to avoid service startup warnings about registering meters with different tag keys on Spring Boot 3.4+. As prior versions of Spring Boot don't seem to set the tag, this change can in turn cause these same warnings on versions older than 3.4. However, given those versions are now out of OSS support, this trade off seems acceptable. This applies the same change we've made in tw-tasks and wise-kafka-producer.
fb9d852 to
f1cbc2a
Compare
Context
Add the
spring.idtag to the kafka client metrics, for created kafka producers, to avoid service startup warnings about registering meters with different tag keys on Spring Boot 3.4+.As prior versions of Spring Boot don't seem to set the tag, this change can in turn cause these same warnings on versions older than 3.4. However, given those versions are now out of OSS support, this trade off seems acceptable.
This applies the same change we've made in tw-tasks and wise-kafka-producer.
Checklist