Fix error message when no private key is provided#40
Open
seveas wants to merge 2 commits intotransip:masterfrom
Open
Fix error message when no private key is provided#40seveas wants to merge 2 commits intotransip:masterfrom
seveas wants to merge 2 commits intotransip:masterfrom
Conversation
This error had me confused for a minute. Had to read this file to realize that I passed an empty string as PrivateKeyPath
Collaborator
|
Hi @seveas, This will make the test expecting that error also fail. Could you also change that test? |
Author
|
Certainly! Apologies for the sloppy pr. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Short description
This error had me confused for a minute. Had to read this file to realize that I passed an empty string as PrivateKeyPath
Checklist
Last 2 are not really applicable 😃