Skip to content

feat(cli): support home credentials resolution#375

Merged
kvz merged 7 commits intomainfrom
feat/home-credentials-cli
Apr 14, 2026
Merged

feat(cli): support home credentials resolution#375
kvz merged 7 commits intomainfrom
feat/home-credentials-cli

Conversation

@kvz
Copy link
Copy Markdown
Member

@kvz kvz commented Apr 14, 2026

Summary

  • add ~/.transloadit/credentials support to the Node CLI with explicit precedence
  • support token or key/secret auth for normal CLI commands while keeping signing/token minting on key/secret
  • improve docs, tests, and missing-auth messaging with concrete lookup paths

Validation

  • yarn workspace @transloadit/node check
  • yarn check

@kvz kvz marked this pull request as ready for review April 14, 2026 10:33
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: bec376382d

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment on lines +117 to +120
if (projectDotenvResult == null) {
projectDotenvInjectedValues = undefined
projectDotenvPreviousValues = undefined
return undefined
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Restore injected .env vars when file disappears

If loadProjectDotenvIntoProcessEnv() is called again in the same working directory after .env has been removed, this branch clears the bookkeeping state but never restores previously injected keys, so stale values remain in process.env. In a long-lived process that invokes main()/runSig() multiple times, deleted credentials or endpoints can still be used on later invocations, which breaks the documented resolution behavior and can apply outdated auth unexpectedly.

Useful? React with 👍 / 👎.

@kvz kvz merged commit 28f1a43 into main Apr 14, 2026
10 checks passed
@kvz kvz deleted the feat/home-credentials-cli branch April 14, 2026 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant