Skip to content

Switch all klog to slog.#896

Merged
mhutchinson merged 2 commits intotransparency-dev:mainfrom
mhutchinson:slog-em-all
Mar 16, 2026
Merged

Switch all klog to slog.#896
mhutchinson merged 2 commits intotransparency-dev:mainfrom
mhutchinson:slog-em-all

Conversation

@mhutchinson
Copy link
Contributor

@mhutchinson mhutchinson commented Mar 10, 2026

This sets up all main files with text logging of the slog to maintain equivalent behaviour. As the klog flags we know and love (logtostderr, alsologtostderr, v) are no longer available, I have created slog_level in all our binaries to allow the log level to be tuned.

@mhutchinson mhutchinson requested a review from a team as a code owner March 10, 2026 12:08
@mhutchinson mhutchinson marked this pull request as draft March 10, 2026 12:10
@mhutchinson mhutchinson force-pushed the slog-em-all branch 4 times, most recently from 1ec1b17 to 0fcad74 Compare March 12, 2026 16:39
@mhutchinson mhutchinson marked this pull request as ready for review March 12, 2026 16:47
This sets up all main files with text logging of the slog to maintain
equivalent behaviour.

Switch over logging flags
@mhutchinson mhutchinson merged commit 30ef2de into transparency-dev:main Mar 16, 2026
14 of 15 checks passed
@mhutchinson mhutchinson deleted the slog-em-all branch March 16, 2026 14:13
mhutchinson added a commit to mhutchinson/trillian-tessera that referenced this pull request Mar 18, 2026
This got missed in transparency-dev#896 and is likely the cause of the conformance failures.
mhutchinson added a commit that referenced this pull request Mar 18, 2026
This got missed in #896 and is likely the cause of the conformance failures.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants