Skip to content

Update linter for slog #907

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mhutchinson merged 1 commit into from
Mar 17, 2026
Merged

Update linter for slog #907

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/golangci-lint.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,4 +24,4 @@ jobs:
uses: golangci/golangci-lint-action@1e7e51e771db61008b38414a730f564565cf7c20 # v9.2.0
with:
version: v2.10.1
args: --timeout=8m --enable=sloglint
args: --timeout=8m
18 changes: 18 additions & 0 deletions .golangci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
version: "2"

linters:
enable:
- depguard
- sloglint
settings:
depguard:
rules:
main:
deny:
- pkg: "k8s.io/klog/v2"
desc: "klog is forbidden, use log/slog instead"
- pkg: "k8s.io/klog"
desc: "klog is forbidden, use log/slog instead"
sloglint:
attr-only: true
context: all
2 changes: 1 addition & 1 deletion storage/gcp/gcp.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -380,7 +380,7 @@ func (a *Appender) publishCheckpointJob(ctx context.Context, pubInterval, republ
}
return nil
}); err != nil {
slog.ErrorContext(ctx, "publishCheckpoint failed", "error", err)
slog.ErrorContext(ctx, "publishCheckpoint failed", slog.Any("error", err))
}
}
}
Expand Down
Loading