Skip to content

πŸ›‘οΈ Sentinel: [CRITICAL] Fix path traversal in auth management handlers#219

Open
rschumann wants to merge 1 commit intomainfrom
sentinel-fix-auth-files-path-traversal-7660994911729275407
Open

πŸ›‘οΈ Sentinel: [CRITICAL] Fix path traversal in auth management handlers#219
rschumann wants to merge 1 commit intomainfrom
sentinel-fix-auth-files-path-traversal-7660994911729275407

Conversation

@rschumann
Copy link
Copy Markdown
Contributor

🚨 Severity: CRITICAL
πŸ’‘ Vulnerability: The UploadAuthFile and DeleteAuthFile management endpoints in internal/api/handlers/management/auth_files.go were using strings.Contains(name, string(os.PathSeparator)) to validate filename inputs. This is insufficient because it only checks the host OS separator, making the application vulnerable to cross-platform traversal bypassing (e.g. using \ characters on Linux instances).
🎯 Impact: An attacker could bypass path validation checks by using alternate path separators, allowing them to read, write, or delete arbitrary files outside of the authorized AuthDir directory if the operating system or underlying Go path functions eventually normalize the path.
πŸ”§ Fix: Replaced the vulnerable validation check with the Sentinel pattern strings.ContainsAny(name, "/\\"), explicitly denying both forward and backward slashes. Also documented the vulnerability and learning in .jules/sentinel.md.
βœ… Verification: Verified by checking code formatting, passing go vet ./internal/api/handlers/management, and successfully running go test ./... -short globally and go test ./internal/api/handlers/management -run TestDownloadAuthFile_PathTraversal specifically.


PR created automatically by Jules for task 7660994911729275407 started by @rschumann

Replaced `strings.Contains(name, string(os.PathSeparator))` with `strings.ContainsAny(name, "/\\")` in the `UploadAuthFile` and `DeleteAuthFile` management endpoints to prevent path traversal on cross-platform systems. Appended a vulnerability learning entry to `.jules/sentinel.md`.

Co-authored-by: rschumann <360788+rschumann@users.noreply.github.com>
@google-labs-jules
Copy link
Copy Markdown
Contributor

πŸ‘‹ Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a πŸ‘€ emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant