Skip to content

⚡ Bolt: Optimize SSE chunk building in hot paths#229

Open
rschumann wants to merge 1 commit intomainfrom
bolt-optimize-openai-stream-chunk-13624251291660405387
Open

⚡ Bolt: Optimize SSE chunk building in hot paths#229
rschumann wants to merge 1 commit intomainfrom
bolt-optimize-openai-stream-chunk-13624251291660405387

Conversation

@rschumann
Copy link
Copy Markdown
Contributor

What

Optimized BuildOpenAIStreamChunkFast and BuildOpenAIStreamFinishChunkFast in cli_openai_format.go by replacing fmt.Sprintf with pre-allocated byte slices and append().

Why

The previous implementation used fmt.Sprintf to format JSON strings and then converted them to []byte, causing unnecessary memory allocations and reflection overhead in the streaming hot path. Every streamed token requires calling this function, making it a critical performance bottleneck.

Impact

  • Reduces memory allocations per chunk by ~75% (8 allocs -> 2 allocs).
  • Improves execution speed by ~46% per chunk (~1300 ns -> ~700 ns) for data chunks.
  • Speeds up finish chunks by ~75% (~654 ns -> ~165 ns).

Measurement

Verified using Go benchmark tool:

BenchmarkBuildOpenAIStreamChunkFastOptimized-4           1838360         699.2 ns/op       768 B/op         2 allocs/op
BenchmarkBuildOpenAIStreamFinishChunkFastOptimized-4     7235449         165.0 ns/op       160 B/op         1 allocs/op

PR created automatically by Jules for task 13624251291660405387 started by @rschumann

Co-authored-by: rschumann <360788+rschumann@users.noreply.github.com>
@google-labs-jules
Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant