⚡ Bolt: Optimize SSE chunk building in hot paths#229
Conversation
Co-authored-by: rschumann <360788+rschumann@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
What
Optimized
BuildOpenAIStreamChunkFastandBuildOpenAIStreamFinishChunkFastincli_openai_format.goby replacingfmt.Sprintfwith pre-allocated byte slices andappend().Why
The previous implementation used
fmt.Sprintfto format JSON strings and then converted them to[]byte, causing unnecessary memory allocations and reflection overhead in the streaming hot path. Every streamed token requires calling this function, making it a critical performance bottleneck.Impact
Measurement
Verified using Go benchmark tool:
PR created automatically by Jules for task 13624251291660405387 started by @rschumann