Skip to content

πŸ›‘οΈ Sentinel: [CRITICAL] Fix Command Injection in browser URL handler#242

Open
rschumann wants to merge 1 commit intomainfrom
sentinel/fix-browser-url-injection-18337675449359256288
Open

πŸ›‘οΈ Sentinel: [CRITICAL] Fix Command Injection in browser URL handler#242
rschumann wants to merge 1 commit intomainfrom
sentinel/fix-browser-url-injection-18337675449359256288

Conversation

@rschumann
Copy link
Copy Markdown
Contributor

🚨 Severity: CRITICAL
πŸ’‘ Vulnerability: The OS-specific URL handler in internal/browser/browser.go used exec.Command directly with the user-supplied URL without any validation, opening up a command injection or SSRF vulnerability if arbitrary or local file URLs were passed.
🎯 Impact: An attacker could craft a malicious URL to execute commands on the host operating system or access local files.
πŸ”§ Fix: Introduced URL scheme validation using net/url.Parse to ensure only http and https schemes are allowed before passing to OS-specific open commands. Also renamed url to rawurl to avoid shadowing the package.
βœ… Verification: Verified by running unit tests (go test ./... -short) and ensuring gosec ./... no longer reports an exploitable path, and go vet ./internal/browser/... passes.


PR created automatically by Jules for task 18337675449359256288 started by @rschumann

Co-authored-by: rschumann <360788+rschumann@users.noreply.github.com>
@google-labs-jules
Copy link
Copy Markdown
Contributor

πŸ‘‹ Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a πŸ‘€ emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant