Async delete - #126
Open
yunenliu wants to merge 3 commits into
Open
Conversation
added 3 commits
August 30, 2020 09:43
…ily used for async delete action)
…n the books example page
…mpty table behind). Also added gecko autodriver as a requirement and imported into tests since I got an error about not having geckodriver on path when I followed the instructions
Owner
|
@yunenliu Nice work. I'll check it out and accept it as soon as possible. Most probably in coming weekend. |
Owner
|
@yunenliu Sorry for not including your PR back in 2020. I'm again working on this package from time to time thus I would like to ask you if you're interested in adjusting this outdated PR to the current code. It would be great to have you as collaborator. Otherwise I would like to thank you for your contribution and include your idea in one of the next releases. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, async deletes don't work because the js submits them twice (once to validate the form, once to actually perform the action). If we assume deletes don't generally require form validation, then the problem is solved by adding a setting that skips the form validation step and submits it directly.
Added async delete code alongside the standard delete code to show how to use the new setting.
Added a functional test of async delete (note that since the page never reloads, now we get an empty table instead of a message that no books are in the database)