Decouple community and enterprise image tags#392
Merged
Conversation
Closes #391 Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
nopcoder
approved these changes
Apr 17, 2026
Contributor
nopcoder
left a comment
nopcoder
left a comment
There was a problem hiding this comment.
LGTM - missing backward support for image.tag
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Member
Author
Thanks! Fixed! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a temporary WA until we decide on a more permanent solution for the charts!
Closes #391
Summary
.Values.image.tag | default .Chart.AppVersionwith a newlakefs.taghelper that picksimage.enterprise.tagwhenenterprise.enabledis true, otherwiseimage.community.tag.Chart.AppVersionfallback) if the selected tag is unset.Test plan
helm templatewith defaults →treeverse/lakefs:1.80.0helm template --set enterprise.enabled=true→treeverse/lakefs-enterprise:1.80.0image.community.tag/image.enterprise.tagindependently produces the expected imagerequiredmessage🤖 Generated with Claude Code