Open
Conversation
Contributor
|
Man, you did a tremendous job. Thank you! I will try to review on the end of next week. Sorry for delay, having rough deadlines on work. |
brettz9
force-pushed
the
lastEnteredVersion
branch
3 times, most recently
from
b0d5e04 to
ce198d3
Compare
Contributor
Author
|
Thanks for your encouragement! I sent one more PR through for when things free up for you... |
brettz9
force-pushed
the
lastEnteredVersion
branch
from
ce198d3 to
9f899ae
Compare
…allow a sequence of upgrades which can support promises returned by `addCallback` callbacks (and add docs and tests for multiple promise-based callbacks on different versions); Commenting: Indicate specific Safari bug within code; Refactoring: Use ES6 `Array.from`; add `Number.isInteger` and ES7 `Object.values()` in place of npm modules (requires babel-polyfill); Testing: Split off local testing from Sauce; prevent blocking; increase timeout for Firefox; add test to throw with previous version
…ted `addCallback` ones, can themselves use idb-schema methods (e.g., to convert from JSON to idb-schema) though, since they execute within `upgradeneeded` cannot support Promises (as can the callbacks within `addCallback` when `schema.open` or `schema.upgrade` are used); document
… added previously) - If `delStore` does throw later (or if there is any other upgrade error), the error can be caught by `callback` or `open`/`upgrade` - Feature: Support `errBack` to `callback` - Expand callback, delStore docs
… at run-time); Fix: Allow stores and indexes to be an empty string; Fix: allow empty-string key path (unless with autoIncrement); Fix: disallow autoIncrement with array keyPath but enable for non-empty strings (as permitted by spec--keys overridable on put()/add()) Testing: Add tests for above
…n so that one can delete old stores or indexes and recreate them if desired (add tests); - Refactoring: Put schema.open/schema.upgrade tests in own "describe" section
brettz9
force-pushed
the
lastEnteredVersion
branch
from
9f899ae to
52c2778
Compare
… order, but the getter will continue to get the highest version. To get the current rather than highest version, the method `lastEnteredVersion()` has been added. - Refactoring: better default behavior for getJSONStorage internal method
brettz9
force-pushed
the
lastEnteredVersion
branch
from
52c2778 to
62d59a7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have a need for entering versions out of order.
Building on the previous PRs, I've added a new method
lastEnteredVersionfor internal use (and for extending classes) to get the current version (i.e., not necessarily the highest version, but the last used), and modified the existingversion(), but this is not really a breaking change sinceversion()would simply throw previously if one tried to enter versions out of order. This method still provides the desired behavior when used as a getter to return the highest version.