Remove argument numbers from denodeify#48
Open
alastaircoote wants to merge 3 commits intotreojs:masterfrom
Open
Remove argument numbers from denodeify#48alastaircoote wants to merge 3 commits intotreojs:masterfrom
alastaircoote wants to merge 3 commits intotreojs:masterfrom
Conversation
plugins/treo-promise/index.js
Outdated
| patch(store, storeMethods); | ||
|
|
||
| Object.keys(store.indexes).forEach(function(indexName) { | ||
|
|
Contributor
There was a problem hiding this comment.
could you remove this new line and console.log?
Author
|
Argh, apologies, fixed. This is what I get for late night coding... |
|
Could this be merged? |
Author
|
@calebeby I've published this as a separate module, at least for now. Should work: |
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As indicated in #45, the treo-promise plugin doesn't work correctly right now. After removing the specified argument numbers it seems to work fine.