feat(labels): add explicit remote label push command#65
Merged
TrevorBasinger merged 1 commit intomainfrom Apr 17, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add an explicit
roar label pushflow for mutating current remote labels without changing existing local-firstroar label setbehavior.This wires
roarto the new GLaaS APIPATCH /api/v1/labels/currentroute and keeps the first client slice tightly scoped:roar label pushWhat changed
roar label push <dag|job|artifact> <target>PATCH /api/v1/labels/currentBehavior notes
roar label setis unchanged and remains local-only404Testing
Ran:
ruff check .ruff format --check .mypy roarpytest tests/application/query/test_label.py tests/unit/test_label_service.py tests/integration/test_label_push_cli_integration.py tests/integration/test_put_cli_integration.py tests/happy_path/test_label_command.pyAlso ran:
pytest -m "not live_glaas and not ebpf"That broader run passed except for one unrelated environment-specific OSMO wheel/platform failure:
tests/backends/osmo/test_osmo_smoke.py::test_osmo_basic_workflow_submit_and_complete