Add Digiwage Support by gdiscord · Pull Request #1121 · trezor/blockbook

gdiscord · 2024-08-07T22:16:47Z

Build - successful
Unit test and Integration test - both successful

explorer url: https://wagescan.digiwage.org

make test-integration ARGS="-run=TestIntegration/digiwage/"
Image blockbook-build is up to date
docker run -t --rm -e PACKAGER=0:0 -v "/root/Temp/blockbook:/src" --network="host" blockbook-build make test-integration ARGS="-run=TestIntegration/digiwage/"
rm -rf /go/src/github.com/trezor/blockbook
mkdir -p /go/src/github.com/trezor
cp -r /src /go/src/github.com/trezor/blockbook
cd /go/src/github.com/trezor/blockbook && go mod download
sed -i 's/wsMessageSizeLimit\ =\ 15\ \*\ 1024\ \*\ 1024/wsMessageSizeLimit = 80 * 1024 * 1024/g' /go/pkg/mod/github.com/ava-labs/coreth*/rpc/websocket.go
cd /go/src/github.com/trezor/blockbook && go test -tags 'integration' `go list github.com/trezor/blockbook/tests/...` -run=TestIntegration/digiwage/
?   	github.com/trezor/blockbook/tests/dbtestdata	[no test files]
?   	github.com/trezor/blockbook/tests/rpc	[no test files]
?   	github.com/trezor/blockbook/tests/sync	[no test files]
ok  	github.com/trezor/blockbook/tests	0.346s

Copilot

Pull Request Overview

Adds Digiwage (WAGE) coin support by introducing its RPC implementation, parser, configuration, and associated test data and unit/integration tests.

Adds Digiwage RPC and parser with custom handling (Zerocoin scripts, shielded tx structure, block version nuances).
Introduces coin configuration and registers Digiwage in blockchain factory map.
Adds test fixtures and unit tests for address/script handling, tx packing/unpacking, and block parsing.

Reviewed Changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated 6 comments.

Show a summary per file

File	Description
configs/coins/digiwage.json	Adds runtime configuration for Digiwage (ports, backend binary, slip44, xpub magic, etc.).
bchain/coins/blockchain.go	Registers Digiwage RPC factory.
bchain/coins/digiwage/digiwagerpc.go	Implements Digiwage-specific RPC wrapper and initialization.
bchain/coins/digiwage/digiwageparser.go	Implements Digiwage parser with Zerocoin and shielded tx handling.
bchain/coins/digiwage/digiwageparser_test.go	Adds unit tests for address/script parsing and tx/block serialization.
bchain/coins/digiwage/testdata/block_dump.11962	Raw block fixture for parser tests.
tests/tests.json	Adds Digiwage to integration test matrix.
tests/rpc/testdata/digiwage.json	RPC fixture for Digiwage (block/tx data).
tests/sync/testdata/digiwage.json	Sync test fixture for block processing and fork handling.

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

Copilot · 2025-10-06T14:01:35Z

+                            }
+                        ],
+                        "blockhash": "25961563bc9afae2b7ed3bc8dc61da40185bbe86096d687f746c632a885a1e01",
+                        "confirmations": 2553878,


Both transactions are in the same block (same blockhash and time) but have different confirmation counts, which is internally inconsistent. Use the same deterministic value (e.g. 1) or omit confirmations in fixtures to avoid misleading or brittle tests.

Suggested change

"confirmations": 2553878,

Copilot · 2025-10-06T14:01:36Z

+                        ],
+                        "hex": "01000000018090210721792f1af27ffa402460b0826b29785d47e7704cfa89e50fc714d9380100000049483045022100a69bf16bbeda76dbeb22541714f640ad2c98f530560b9090848c63b718ef4aba02203fc5be3622bdad8316b502e405d62871ffba0e57c41f5b43fdc7047f793b924f01ffffffff03000000000000000000cb25ac0f3c0000002321030e55883d14ce52ba7b3ab23a61dfc50241333a8ee748029ec849ac036676b1d9ac00286bee000000001976a9142ccad575530bcb760a9365820b837787928390fd88ac00000000",
+                        "blockhash": "25961563bc9afae2b7ed3bc8dc61da40185bbe86096d687f746c632a885a1e01",
+                        "confirmations": 2553889,


Both transactions are in the same block (same blockhash and time) but have different confirmation counts, which is internally inconsistent. Use the same deterministic value (e.g. 1) or omit confirmations in fixtures to avoid misleading or brittle tests.

Suggested change

"confirmations": 2553889,

"confirmations": 1,

Copilot · 2025-10-06T14:01:36Z

+            "blockhash": "25961563bc9afae2b7ed3bc8dc61da40185bbe86096d687f746c632a885a1e01",
+            "time": 1536318380,
+            "blocktime": 1536318380,
+            "confirmations": 0


Transaction includes blockhash and block metadata yet confirmations is 0, which contradicts a confirmed state. Set this to a positive value (e.g. 1) or remove the field if not asserted in tests.

Suggested change

"confirmations": 0

"confirmations": 1

Copilot · 2025-10-06T14:01:36Z

+    "system_user": "blockbook-digiwage",
+    "internal_binding_template": ":{{.Ports.BlockbookInternal}}",
+    "public_binding_template": ":{{.Ports.BlockbookPublic}}",
+    "explorer_url": "",


[nitpick] explorer_url is empty but the PR description provides https://wagescan.digiwage.org; populating it improves discoverability and parity with other coin configs.

Suggested change

"explorer_url": "",

"explorer_url": "https://wagescan.digiwage.org",

Copilot · 2025-10-06T14:01:37Z

+	if txCount > maxTxPerBlock {
+		str := fmt.Sprintf("too many transactions to fit into a block "+
+			"[count %d, max %d]", txCount, maxTxPerBlock)
+		return &wire.MessageError{Func: "utils.decodeTransactions", Description: str}


The Func field references 'utils.decodeTransactions' which does not match the actual function name (DigiwageDecodeTransactions), reducing traceability. Update the string to 'DigiwageDecodeTransactions' for accurate error provenance.

Suggested change

return &wire.MessageError{Func: "utils.decodeTransactions", Description: str}

return &wire.MessageError{Func: "DigiwageDecodeTransactions", Description: str}

Copilot · 2025-10-06T14:01:37Z

+	name := fmt.Sprintf("block_dump.%d", height)
+	path := filepath.Join("testdata", name)
+
+	d, err := ioutil.ReadFile(path)


ioutil.ReadFile is deprecated; replace with os.ReadFile for current Go versions.

Suggested change

d, err := ioutil.ReadFile(path)

d, err := os.ReadFile(path)

Add Digiwage Support

0221fb8

MiroslavProchazka requested a review from Copilot October 6, 2025 13:58

Copilot AI reviewed Oct 6, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Add Digiwage Support#1121

Add Digiwage Support#1121
gdiscord wants to merge 1 commit intotrezor:masterfrom
gdiscord:master

gdiscord commented Aug 7, 2024

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Oct 6, 2025

Uh oh!

Copilot AI Oct 6, 2025

Uh oh!

Copilot AI Oct 6, 2025

Uh oh!

Copilot AI Oct 6, 2025

Uh oh!

Copilot AI Oct 6, 2025

Uh oh!

Copilot AI Oct 6, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

	"explorer_url": "",
	"explorer_url": "https://wagescan.digiwage.org",

	return &wire.MessageError{Func: "utils.decodeTransactions", Description: str}
	return &wire.MessageError{Func: "DigiwageDecodeTransactions", Description: str}

Uh oh!

Conversation

gdiscord commented Aug 7, 2024

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Copilot AI Oct 6, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 6, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 6, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 6, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 6, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 6, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants