Short-circuit address parsing on hot path during block processing #1395
Open
pragmaxim wants to merge 2 commits intoresync-mempool-using-batch-apifrom
Open
Short-circuit address parsing on hot path during block processing #1395pragmaxim wants to merge 2 commits intoresync-mempool-using-batch-apifrom
pragmaxim wants to merge 2 commits intoresync-mempool-using-batch-apifrom
Conversation
4e88372 to
c5f8539
Compare
aec6adf to
331c523
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary Of Changes
addressFromPaddedHexby decoding the last 20 bytes directly when the input is a 32-byte padded topic or calldata slot, and fall back to big.Int only for odd formats.addressFromPaddedHex.addressFromPaddedHex: What Was Wrong And How It Was Fixed
0x, fast-path decode the last 40 hex characters (20 bytes) viahex.DecodeStringandBytesToAddress, and fall back to the original big.Int parse only when the fast path does not apply or fails.