emit: allow mpy-cross to exclude source lines' data#29
Merged
romanz merged 1 commit intotrezor-v1.19.1from Apr 13, 2026
Merged
Conversation
romanz
changed the title
mpy-cross to exclude source lines' data
romanz
added a commit
to trezor/trezor-firmware
that referenced
this pull request
Apr 9, 2026
Fixes #6715. Needs trezor/micropython#29. [no changelog]
romanz
force-pushed
the
romanz/no-source-lines
branch
from
e745949 to
7f2b41a
Compare
romanz
added a commit
to trezor/trezor-firmware
that referenced
this pull request
Apr 9, 2026
Fixes #6715. Needs trezor/micropython#29. [no changelog]
Author
|
Renamed the flag to |
romanz
added a commit
to trezor/trezor-firmware
that referenced
this pull request
Apr 9, 2026
Fixes #6715. Needs trezor/micropython#29. [no changelog]
mmilata
approved these changes
Apr 9, 2026
Member
mmilata
left a comment
mmilata
left a comment
There was a problem hiding this comment.
LGTM, does it make sense to submit upstream?
cepetr
approved these changes
Apr 10, 2026
cepetr
reviewed
Apr 10, 2026
romanz
force-pushed
the
romanz/no-source-lines
branch
from
7f2b41a to
8c12312
Compare
Author
|
Upstream PR: micropython#19080 |
This would allow building debug FW without source line data. Signed-off-by: Roman Zeyde <me@romanzey.de>
romanz
force-pushed
the
romanz/no-source-lines
branch
from
8c12312 to
e8d89a0
Compare
mmilata
approved these changes
Apr 13, 2026
romanz
added a commit
to trezor/trezor-firmware
that referenced
this pull request
Apr 13, 2026
Fixes #6715. Needs trezor/micropython#29. [no changelog]
romanz
added a commit
to trezor/trezor-firmware
that referenced
this pull request
Apr 13, 2026
Fixes #6715. Needs trezor/micropython#29. [no changelog]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This would allow having debug FW builds without source line data.
The new
emit_no_source_linesflag is disabled by default, and is used only bympy-cross.Will be used by trezor/trezor-firmware#6736 to resolve trezor/trezor-firmware#6715.
Upstream PR: micropython#19080