feat+perf: [alb/fanout,proxy/capture] loser-drain histogram + capture body presize#1014
Open
crandles wants to merge 3 commits into
Open
feat+perf: [alb/fanout,proxy/capture] loser-drain histogram + capture body presize#1014crandles wants to merge 3 commits into
crandles wants to merge 3 commits into
Conversation
Signed-off-by: Chris Randles <randles.chris@gmail.com>
Signed-off-by: Chris Randles <randles.chris@gmail.com>
Signed-off-by: Chris Randles <randles.chris@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
trickster_alb_fanout_loser_drain_seconds{mechanism,variant}histogram onWaitForFirst. After fix+refactor+test: [alb/cache/proxy] continued hardening sweep #1006, losers drain in the background after winner-claim and there's no way to tell sub-ms healthy drains from upstreams ignoring ctx-cancel.CaptureResponseWriter.WriteHeaderpresizes body fromContent-Length, bounded bymaxBytes. Multi-MB time-series captures otherwise pay severalbytes.Bufferdoublings.Type of Change
AI Disclosure
Expect this will fail until #1012 merges (it includes a fix / main is currently failing tests)