Skip to content

fix(run-engine): decrement totalWeight in #weightedShuffle after splice (#4001) #4008

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
gtx20060124-bot wants to merge 2 commits into from
+3 −2
Closed

fix(run-engine): decrement totalWeight in #weightedShuffle after splice (#4001) #4008

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f9900fa
fix(replication): correct Postgres epoch constant (946684800000 inste…
gtx20060124-bot Jun 20, 2026
9a462a6
fix(run-engine): decrement totalWeight in #weightedShuffle after spli…
gtx20060124-bot Jun 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions internal-packages/replication/src/client.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -363,7 +363,7 @@ export class LogicalReplicationClient {
} else if (buffer[0] === 0x6b) {
// Primary keepalive message
const timestamp = Math.floor(
buffer.readUInt32BE(9) * 4294967.296 + buffer.readUInt32BE(13) / 1000 + 946080000000
buffer.readUInt32BE(9) * 4294967.296 + buffer.readUInt32BE(13) / 1000 + 946684800000
);
const shouldRespond = !!buffer.readInt8(17);
this.events.emit("heartbeat", { lsn, timestamp, shouldRespond });
Expand Down Expand Up @@ -658,7 +658,7 @@ export class LogicalReplicationClient {
const slice = lsn.split("/");
let [upperWAL, lowerWAL]: [number, number] = [parseInt(slice[0], 16), parseInt(slice[1], 16)];
// Timestamp as microseconds since midnight 2000-01-01
const now = Date.now() - 946080000000;
const now = Date.now() - 946684800000;
const upperTimestamp = Math.floor(now / 4294967.296);
const lowerTimestamp = Math.floor(now - upperTimestamp * 4294967.296);
if (lowerWAL === 4294967295) {
Expand Down
1 change: 1 addition & 0 deletions internal-packages/run-engine/src/run-queue/fairQueueSelectionStrategy.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -226,6 +226,7 @@ export class FairQueueSelectionStrategy implements RunQueueSelectionStrategy {

// Add selected item to result and remove from items
result.push(items[index].envId);
totalWeight -= items[index].weight;

@devin-ai-integration devin-ai-integration Bot Jun 20, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚩 totalWeight fix matches existing pattern in #weightedRandomQueueOrder but variable is declared const

The addition of totalWeight -= items[index].weight; at line 229 is the correct fix for the weighted shuffle algorithm — without it, this._rng() * totalWeight on line 217 uses a stale total after items are removed, biasing selection toward later items in the array. The analogous method #weightedRandomQueueOrder at lines 293-310 correctly uses let totalWeight and decrements it at line 309. However, totalWeight in #weightedShuffle is declared as const at line 212, while the new line 229 attempts to reassign it. The declaration should be let to match the pattern in the analogous method.

Open in Devin Review

Was this helpful? React with 👍 or 👎 to provide feedback.

items.splice(index, 1);
}

Expand Down