Skip to content

Add vortex street example file#1221

Open
efaulhaber wants to merge 9 commits into
trixi-framework:mainfrom
efaulhaber:vortex-street
Open

Add vortex street example file#1221
efaulhaber wants to merge 9 commits into
trixi-framework:mainfrom
efaulhaber:vortex-street

Conversation

@efaulhaber

@efaulhaber efaulhaber commented May 27, 2026

Copy link
Copy Markdown
Member

Ported from #781.

grafik

Co-authored-by: Niklas Neher <73897120+LasNikas@users.noreply.github.com>
@efaulhaber efaulhaber self-assigned this May 27, 2026
@efaulhaber efaulhaber added the enhancement New feature or request label May 27, 2026
@efaulhaber efaulhaber requested review from LasNikas and svchb May 27, 2026 13:03
@efaulhaber efaulhaber marked this pull request as ready for review May 27, 2026 13:04
@efaulhaber efaulhaber requested a review from Copilot May 27, 2026 13:04

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds a new 2D “vortex street” fluid example (flow past a circular cylinder, based on Tafuni et al. 2018) and wires it into the examples test suite to ensure it runs successfully and without RHS allocations.

Changes:

  • Add examples/fluid/vortex_street_2d.jl defining the vortex street simulation setup (fluid system, open boundaries, wall/cylinder boundaries, callbacks, solve).
  • Add a corresponding @trixi_testset in test/examples/examples_fluid.jl to execute the example for a short tspan and validate success + zero RHS allocations.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
test/examples/examples_fluid.jl Adds a test entry to run the new vortex street example and assert success/no allocations.
examples/fluid/vortex_street_2d.jl Introduces the full vortex-street simulation configuration with open boundaries and cylinder obstacle.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread examples/fluid/vortex_street_2d.jl Outdated
Comment thread examples/fluid/vortex_street_2d.jl
@codecov

codecov Bot commented May 27, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.04%. Comparing base (f883a8a) to head (08e758d).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1221   +/-   ##
=======================================
  Coverage   90.04%   90.04%           
=======================================
  Files         136      136           
  Lines       10596    10596           
=======================================
  Hits         9541     9541           
  Misses       1055     1055           
Flag Coverage Δ
total 90.05% <ø> (ø)
unit 70.77% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Comment thread examples/fluid/vortex_street_2d.jl Outdated
Comment thread examples/fluid/vortex_street_2d.jl Outdated
Comment thread examples/fluid/vortex_street_2d.jl Outdated
Comment thread examples/fluid/vortex_street_2d.jl Outdated
Comment thread examples/fluid/vortex_street_2d.jl
Comment thread examples/fluid/vortex_street_2d.jl Outdated
@efaulhaber efaulhaber requested a review from LasNikas June 2, 2026 08:23
Comment thread examples/fluid/vortex_street_2d.jl
Comment thread examples/fluid/vortex_street_2d.jl Outdated
open_boundary_size = (particle_spacing * open_boundary_layers, domain_size[2])

flow_direction = SVector(1.0, 0.0)
reynolds_number = 200

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

move down to where it is used

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the "Experiment Setup" section. We always define values like flow direction and Reynolds number there.

Comment thread examples/fluid/vortex_street_2d.jl Outdated
@efaulhaber efaulhaber requested a review from svchb June 8, 2026 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants