Add vortex street example file#1221
Conversation
Co-authored-by: Niklas Neher <73897120+LasNikas@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
This PR adds a new 2D “vortex street” fluid example (flow past a circular cylinder, based on Tafuni et al. 2018) and wires it into the examples test suite to ensure it runs successfully and without RHS allocations.
Changes:
- Add
examples/fluid/vortex_street_2d.jldefining the vortex street simulation setup (fluid system, open boundaries, wall/cylinder boundaries, callbacks, solve). - Add a corresponding
@trixi_testsetintest/examples/examples_fluid.jlto execute the example for a shorttspanand validate success + zero RHS allocations.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
test/examples/examples_fluid.jl |
Adds a test entry to run the new vortex street example and assert success/no allocations. |
examples/fluid/vortex_street_2d.jl |
Introduces the full vortex-street simulation configuration with open boundaries and cylinder obstacle. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1221 +/- ##
=======================================
Coverage 90.04% 90.04%
=======================================
Files 136 136
Lines 10596 10596
=======================================
Hits 9541 9541
Misses 1055 1055
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
| open_boundary_size = (particle_spacing * open_boundary_layers, domain_size[2]) | ||
|
|
||
| flow_direction = SVector(1.0, 0.0) | ||
| reynolds_number = 200 |
There was a problem hiding this comment.
move down to where it is used
There was a problem hiding this comment.
This is the "Experiment Setup" section. We always define values like flow direction and Reynolds number there.
Ported from #781.