Skip to content

Fix interpolation with VelocityAveraging#1235

Draft
efaulhaber wants to merge 132 commits into
trixi-framework:mainfrom
efaulhaber:fix-interpolation-averaging
Draft

Fix interpolation with VelocityAveraging#1235
efaulhaber wants to merge 132 commits into
trixi-framework:mainfrom
efaulhaber:fix-interpolation-averaging

Conversation

@efaulhaber

Copy link
Copy Markdown
Member

Based on #1037.

When interpolating the initial state or after restarting from files (especially when interpolating from VTK files in postprocessing), velocity averaging is not initialized correctly, which leads to zero wall velocity even if the structure is moving. With this PR, interpolation from VTK files in postprocessing works as intended.

marcelschurer and others added 30 commits October 17, 2025 16:03
@efaulhaber efaulhaber self-assigned this Jun 18, 2026
@efaulhaber efaulhaber added the bug Something isn't working label Jun 18, 2026
@codecov

codecov Bot commented Jun 18, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 90.80460% with 16 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.09%. Comparing base (06db3d9) to head (7b89225).
⚠️ Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
src/general/restart.jl 81.35% 11 Missing ⚠️
.../schemes/boundary/wall_boundary/monaghan_kajtar.jl 0.00% 2 Missing ⚠️
src/general/semidiscretization.jl 95.00% 1 Missing ⚠️
src/schemes/boundary/open_boundary/system.jl 97.29% 1 Missing ⚠️
src/schemes/boundary/wall_boundary/system.jl 90.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1235      +/-   ##
==========================================
+ Coverage   90.04%   90.09%   +0.05%     
==========================================
  Files         136      137       +1     
  Lines       10596    10753     +157     
==========================================
+ Hits         9541     9688     +147     
- Misses       1055     1065      +10     
Flag Coverage Δ
total 90.10% <90.80%> (+0.05%) ⬆️
unit 75.19% <90.80%> (+4.41%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants