Add partialRefetch as an option#159
Add partialRefetch as an option#159estrada9166 wants to merge 4 commits intotrojanowski:masterfrom estrada9166:add-partialRefetch-as-option
Conversation
|
Thanks @estrada9166. Could you add a unit test for it? |
| fetchPolicy !== 'cache-only' | ||
| ) { | ||
| const partialRefetchResult = { | ||
| ...result.data, |
There was a problem hiding this comment.
These are empty so maybe it would be better, to keep stale data from previous result using useRef.
There was a problem hiding this comment.
or maybe handle this here in a similar way as error is https://github.com/trojanowski/react-apollo-hooks/pull/159/files#diff-9affe4a75e3f039c2a00e27c8bf815aeR148
There was a problem hiding this comment.
BTW, sorry to invade this PR without introduction. I didn't catch it in time and coded basically the same thing yesterday evening. So now I'm just sharing my experience. Thanks for the PR!
There was a problem hiding this comment.
Thanks for the comments! I'll update the PR with this! is much better.
There was a problem hiding this comment.
FWIW Also this one is related to the need of showing stale data:
#134
|
@brabeji Any new for this? :) Thanks! |
|
@trufa I'm using a locally patched version of |
4 participants
fix #128
Taken from here