added a shoppingCart model #11
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Elena-Bruyako
suggested changes
Mar 3, 2025
Comment on lines
79
to
81
| if (authentication == null || !(authentication.getPrincipal() instanceof User)) { | ||
| throw new EntityNotFoundException("Authentication failed. User not found."); | ||
| } |
There was a problem hiding this comment.
Suggested change
| if (authentication == null || !(authentication.getPrincipal() instanceof User)) { | |
| throw new EntityNotFoundException("Authentication failed. User not found."); | |
| } |
|
|
||
| @Data | ||
| public class CartItemRequestDto { | ||
| @NotNull |
There was a problem hiding this comment.
Suggested change
| @NotNull | |
| @NotNull | |
| @Positive |
Comment on lines
12
to
13
| @Min(value = 1, | ||
| message = "Quantity must be at least 1") |
| @GeneratedValue(strategy = GenerationType.IDENTITY) | ||
| private Long id; | ||
|
|
||
| @OneToOne(fetch = FetchType.LAZY, optional = false) |
| @Table(name = "shopping_carts") | ||
| public class ShoppingCart { | ||
| @Id | ||
| @GeneratedValue(strategy = GenerationType.IDENTITY) |
There was a problem hiding this comment.
Suggested change
| @GeneratedValue(strategy = GenerationType.IDENTITY) |
Comment on lines
9
to
10
| @Query("SELECT sc FROM ShoppingCart sc LEFT JOIN FETCH sc.cartItems " | ||
| + "WHERE sc.user.id = :userId AND sc.user.isDeleted = false") |
There was a problem hiding this comment.
Suggested change
| @Query("SELECT sc FROM ShoppingCart sc LEFT JOIN FETCH sc.cartItems " | |
| + "WHERE sc.user.id = :userId AND sc.user.isDeleted = false") | |
| @EntityGraph(attributePaths = {"cartItems", "cartItems.book"}) |
| } | ||
|
|
||
| @Override | ||
| @Transactional |
| .orElseThrow(() -> new EntityNotFoundException("Default role not found")); | ||
| user.setRoles(Set.of(defaultRole)); | ||
| userRepository.save(user); | ||
|
|
JJJazl
approved these changes
Mar 4, 2025
JJJazl
left a comment
JJJazl
left a comment
There was a problem hiding this comment.
Great! Let's move on, left one minor comment)
| .findFirst(); | ||
|
|
||
| if (existingCartItem.isPresent()) { | ||
| CartItem cartItem = existingCartItem.get(); |
There was a problem hiding this comment.
It is recommended to use orElseThrow() instead of `get()'. You can also see this in the java doc
Suggested change
| CartItem cartItem = existingCartItem.get(); | |
| CartItem cartItem = existingCartItem.orElseThrow(); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.