Modernize the project a bit (deps, infra, etc)#214
Merged
Conversation
The jline terminal echoes input with control characters (backspace, cursor movement) between the prompt and output, so the regex needs dotall mode and a wildcard to match across them.
bbatsov
force-pushed
the
modernize-project
branch
from
fe52476 to
bb0184c
Compare
Add Lein profiles for Clojure 1.8-1.12 to support testing across multiple versions.
Test across JDK 8, 11, 17, 21, 25 with Clojure 1.8-1.12 on JDK 8 and 1.10-1.12 on JDK 25.
bbatsov
force-pushed
the
modernize-project
branch
from
bb0184c to
c78dd40
Compare
pst, doc, and find-doc are guaranteed to be in clojure.repl since well before our minimum Clojure 1.8.
bbatsov
changed the title
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The *e integration test expected
user=> #errorliterally, but jline echoes input with terminal control characters between the prompt and output. Added dotall mode and a wildcard to the regex so it matches across them.Okay, I've started with looking into this test, but ended up changing a lot of stuff. Most notably I dropped CircleCI as not being admin, I couldn't fix its deployment tokens. (and I'm more used to GHA in general)