Conversation
jline 2.14.6 is EOL; replace with org.jline/jline 3.28.0 (the latest release still supporting Java 8+). Key changes: - Replace all jline2 imports with jline3 equivalents (LineReader, LineReaderBuilder, TerminalBuilder, etc.) - Rewrite terminal/reader setup using jline3's builder pattern - Update Completer interface to jline3's (LineReader, ParsedLine, List<Candidate>) signature - Add history file format migration (renames old jline2-format files) - Suppress jline3's JUL logging noise (replaces old Log.setOutput hack) - Bypass jline3 for piped/non-interactive input since jline3's DumbTerminal doesn't support ByteArrayInputStream; use a simple BufferedReader instead
Closed
Move test jars from spec/ to target/test-jars/ and remove the spec/ directory entirely now that all tests use clojure.test.
bbatsov
force-pushed
the
migrate-jline2-to-jline3
branch
from
8d7b4a9 to
03b6475
Compare
Collaborator
Author
|
Mission successful! 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
jline 2.14.6 is EOL. This replaces it with org.jline/jline 3.28.0, the latest stable release still supporting Java 8+ (4.x requires Java 11+).
The jline3 API is significantly different so all integration code was rewritten: terminal/reader setup uses the builder pattern, the Completer interface now takes
(LineReader, ParsedLine, List<Candidate>), and history is managed byDefaultHistory. One notable workaround: jline3'sDumbTerminaldoesn't properly handleByteArrayInputStream(throwsEndOfFileExceptionimmediately instead of reading data), so piped/non-interactive input bypasses jline3 entirely and uses a simpleBufferedReader. Old jline2-format history files are automatically renamed on first run.All existing tests pass, including integration tests with both standalone and nREPL modes.