Skip to content

TEST: Verify docs.yml hashFiles function works correctly (Issue #29)#32

Merged
trsdn merged 3 commits into
mainfrom
test/docs-workflow-hashfiles-fix
Sep 17, 2025
Merged

TEST: Verify docs.yml hashFiles function works correctly (Issue #29)#32
trsdn merged 3 commits into
mainfrom
test/docs-workflow-hashfiles-fix

Conversation

@trsdn

@trsdn trsdn commented Sep 17, 2025

Copy link
Copy Markdown
Owner

Purpose

This is a test PR to verify that the hashFiles function in docs.yml workflow is working correctly after the fix in PR #25.

Issue Testing

What This Tests

  1. hashFiles syntax: Verifies if: hashFiles('docs/conf.py') != '' works without syntax errors
  2. Workflow validation: Confirms the docs.yml workflow passes GitHub Actions validation
  3. Conditional logic: Tests that the condition properly evaluates when docs/conf.py exists

Expected Results

  • ✅ Documentation CI workflow should trigger successfully
  • ✅ Build Sphinx Docs job should run (since docs/conf.py exists)
  • ✅ No "unrecognized function" errors
  • ✅ Workflow completes without hashFiles-related failures

Test Change

  • Added a test comment to docs/README.md to trigger the documentation workflow
  • This is a minimal, safe change that exercises the docs workflow paths

Verification Plan

  1. Check that Documentation CI workflow runs
  2. Verify Build Sphinx Docs job executes (confirms hashFiles condition worked)
  3. Confirm no syntax errors in workflow validation
  4. Close this PR once testing is complete

This is a temporary test PR and will be closed after verification.

Add test comment to docs/README.md to trigger documentation workflow
and verify that the hashFiles('docs/conf.py') != '' condition works
without syntax errors after the fix in PR #25.

This tests Issue #29 resolution.
@github-actions

github-actions Bot commented Sep 17, 2025

Copy link
Copy Markdown
Contributor

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Scanned Files

None

The hashFiles function requires wrapper in if conditions.
This fixes the Unrecognized function hashFiles error on line 66.

Fixes Issue #29 properly by using correct GitHub Actions syntax.
@github-actions

Copy link
Copy Markdown
Contributor

🔍 CI Quality Gates Summary

Overall Status: ✅ All Passed

Check Status Details Action Required
🎨 Format ✅ Passed ruff format check None
🔧 Lint ✅ Passed ruff linting None
📝 Types ✅ Passed mypy type checking None
🧪 Tests ✅ Passed Unit tests None
📊 Coverage 80.5% Minimum: 80% None
🔌 MCP ✅ Valid Protocol compliance None
🔒 Security ✅ Clean Dependency audit None

🔗 Quick Links

🛠️ Quick Fix Commands

# Fix most issues automatically
ruff format .
ruff check . --fix

# Run tests locally
pytest tests/unit/ --cov=markitdown_mcp

# Check types
mypy markitdown_mcp

Last updated: 2025-09-17 19:55:38 UTC

@github-actions

Copy link
Copy Markdown
Contributor

🔍 PR Quality Summary

CI Status

✅ Security: success
✅ Quality: success

Metrics

Metric Value Trend
📊 Coverage N/A -
🧪 Tests Test results unavailable -
⏱️ Performance No performance data -

Quality Checks

  • Format & Lint: Ruff formatting and linting
  • Type Safety: MyPy strict type checking
  • Security: Bandit, Safety, GitLeaks scanning
  • MCP Protocol: Tool schema validation
  • Documentation: Docstring coverage (80%+)

MCP Tools

  • convert_file - Convert individual files to Markdown
  • convert_directory - Batch convert directories
  • list_supported_formats - Query supported file types

🤖 Auto-generated by CI • Last updated: 2025-09-17 20:00 UTC

@trsdn trsdn marked this pull request as ready for review September 17, 2025 20:02
@trsdn trsdn merged commit c581a76 into main Sep 17, 2025
100 of 101 checks passed
@trsdn trsdn deleted the test/docs-workflow-hashfiles-fix branch September 17, 2025 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant