fix: resolve MCP protocol and file validation issues#44
Merged
Conversation
Fix OOXML file validation so DOCX/XLSX/PPTX ZIP containers are not routed through XML sanitization. Add MARKITDOWN_SAFE_DIRS support, handle missing home directories safely, make tools/list schema Claude-compatible, and avoid responses for JSON-RPC notifications. Stabilize performance tests with warmup and realistic memory-efficiency checks. Refs #36 Refs #38 Closes #40 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
🔍 PR Analysis ResultsPR: #44 | Commit: 🎨 Code Formatting✅ All files properly formatted 🔧 Code Linting✅ No linting issues found 📝 Type Checking❌ Type checking issues found Click to see type issuesFix: Add proper type annotations and resolve type errors 🔒 Security Analysis✅ No security issues detected 📊 Test Coverage Analysis✅ Coverage 82.02247191011236% meets 80% requirement 🧹 Dead Code Analysis✅ Dead code analysis completed 📋 Summary
🔧 Quick Fix Commands:# Fix formatting and auto-fixable linting issues
ruff format .
ruff check . --fix
# Run tests with coverage
pytest tests/unit/ --cov=markitdown_mcp --cov-report=term-missing
# Check security
bandit -r markitdown_mcp/This analysis was automatically generated by the PR feedback workflow. |
Contributor
🔍 CI Quality Gates SummaryOverall Status: ✅ All Passed
🔗 Quick Links🛠️ Quick Fix Commands# Fix most issues automatically
ruff format .
ruff check . --fix
# Run tests locally
pytest tests/unit/ --cov=markitdown_mcp
# Check types
mypy markitdown_mcpLast updated: 2026-06-10 10:49:24 UTC |
Contributor
🔍 PR Quality SummaryCI Status✅ Security: success Metrics
Quality Checks
MCP Tools
🤖 Auto-generated by CI • Last updated: 2026-06-10 10:52 UTC |
4 tasks
This was referenced Jun 10, 2026
trsdn
pushed a commit
that referenced
this pull request
Jun 10, 2026
## 🚀 Version Bump: v1.2.2 This PR bumps the package version after the merged fixes and performance cleanup. ### 📊 Release Summary - **Version Type**: patch - **New Version**: v1.2.2 - **Commits Included**: consolidated fixes from #44 and performance cleanup from #43 ### 📝 Changelog Preview ### 🐛 Bug Fixes - Resolve MCP protocol and file validation issues (#44) ### ⚡ Performance - Remove artificial path validation delay (#43) ### 🎯 What Happens Next 1. **Review**: Maintainers review this version bump 2. **Merge**: When merged, a git tag `v1.2.2` will be created 3. **Release**: The tag will trigger the automated release workflow 4. **Publish**: Package will be published to PyPI automatically ### ✅ Pre-Release Checklist - [x] Version number looks correct - [x] Changelog entries are accurate - [x] No breaking changes in patch release - [ ] All CI checks pass --- *This PR was originally created automatically by the version bump workflow and updated after #43 merged.*
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
MARKITDOWN_SAFE_DIRSsupport and make safe-directory initialization robust when home cannot be resolvedtools/listschema compatible with Claude/Anthropic clients and stop responding to JSON-RPC notificationsValidation
python3 -m ruff check .PATH="/Library/Frameworks/Python.framework/Versions/3.12/bin:$PATH" python3 -m pytest -qRefs #36
Refs #38
Closes #40
Acknowledgements
Thanks to @kdjkdjkdj for opening #37 and #39 with the Windows/MCP protocol fixes and configurable safe-directory work, and to @pagatino-afk for opening #41 with the Office Open XML corruption fix. Those contributions helped identify and validate the issues consolidated in this PR.