Skip to content

Update the install script to install in local path by default#1

Merged
mohit-a21 merged 2 commits into
mainfrom
install_script
Jun 25, 2026
Merged

Update the install script to install in local path by default#1
mohit-a21 merged 2 commits into
mainfrom
install_script

Conversation

@mohit-a21

@mohit-a21 mohit-a21 commented Jun 25, 2026

Copy link
Copy Markdown
Collaborator

Note

Low Risk
Changes are limited to install script, documentation, and CI lint removal—no application runtime code is modified.

Overview
Install script now defaults to ~/.local/bin when that directory is already on PATH (avoiding sudo when possible), otherwise /usr/local/bin. It prints the exact binary paths after install, batches mkdir/mv into one sudo invocation (fewer password prompts), and adds uninstall steps to the post-install message.

Docs (README.md, docs/getting-started.md) describe the new install locations, add a collapsible Uninstall section (downca remove → remove binaries → optional ~/.aitori), and note that upgrades are just re-running the installer.

CI drops the golangci-lint workflow job and deletes .golangci.yml; go vet in the test job remains.

Reviewed by Cursor Bugbot for commit 4e1246c. Bugbot is set up for automated code reviews on this repo. Configure here.

Comment thread install.sh Outdated
Signed-off-by: Mohit Agarwal <mohit.agarwal@truefoundry.com>
Signed-off-by: Mohit Agarwal <mohit.agarwal@truefoundry.com>
@mohit-a21
mohit-a21 merged commit 4d3d2e8 into main Jun 25, 2026
10 checks passed
@mohit-a21
mohit-a21 deleted the install_script branch June 25, 2026 11:01

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 4e1246c. Configure here.

Comment thread install.sh
info "installed aitori $tag to $INSTALL_DIR"
info "installed aitori $tag to:"
info " $INSTALL_DIR/aitori"
info " $INSTALL_DIR/aitori-gateway"

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gateway path always reported installed

Low Severity

After install, the script always logs and documents $INSTALL_DIR/aitori-gateway as installed, even though the gateway binary is only moved when it exists in the extracted tarball. Users can believe a binary was written when it was not.

Additional Locations (1)
Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit 4e1246c. Configure here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants