Update the install script to install in local path by default#1
Merged
Conversation
mohit-a21
force-pushed
the
install_script
branch
from
June 25, 2026 10:47
f3d1d98 to
38f5102
Compare
Signed-off-by: Mohit Agarwal <mohit.agarwal@truefoundry.com>
mohit-a21
force-pushed
the
install_script
branch
from
June 25, 2026 10:54
38f5102 to
a8e2d88
Compare
LordGameleo
approved these changes
Jun 25, 2026
Signed-off-by: Mohit Agarwal <mohit.agarwal@truefoundry.com>
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 4e1246c. Configure here.
| info "installed aitori $tag to $INSTALL_DIR" | ||
| info "installed aitori $tag to:" | ||
| info " $INSTALL_DIR/aitori" | ||
| info " $INSTALL_DIR/aitori-gateway" |
There was a problem hiding this comment.
Gateway path always reported installed
Low Severity
After install, the script always logs and documents $INSTALL_DIR/aitori-gateway as installed, even though the gateway binary is only moved when it exists in the extracted tarball. Users can believe a binary was written when it was not.
Additional Locations (1)
Reviewed by Cursor Bugbot for commit 4e1246c. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Note
Low Risk
Changes are limited to install script, documentation, and CI lint removal—no application runtime code is modified.
Overview
Install script now defaults to
~/.local/binwhen that directory is already onPATH(avoidingsudowhen possible), otherwise/usr/local/bin. It prints the exact binary paths after install, batchesmkdir/mvinto onesudoinvocation (fewer password prompts), and adds uninstall steps to the post-install message.Docs (
README.md,docs/getting-started.md) describe the new install locations, add a collapsible Uninstall section (down→ca remove→ remove binaries → optional~/.aitori), and note that upgrades are just re-running the installer.CI drops the
golangci-lintworkflow job and deletes.golangci.yml;go vetin the test job remains.Reviewed by Cursor Bugbot for commit 4e1246c. Bugbot is set up for automated code reviews on this repo. Configure here.