Use email OTP signup in onboarding skill#50
Open
mnvsk97 wants to merge 2 commits into
Open
Conversation
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 60b4f74. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
TFY_REGISTRATION_SERVER_URLas an override.x-truefoundry-registration-source: skillsso backend metadata records signup source.Scope
Only the onboarding skill instructions changed. Other skills are untouched.
Validation
git diff --check./scripts/validate-skills.sh./scripts/validate-skill-security.shNote
Medium Risk
Updates onboarding instructions to perform tenant signup via terminal-based OTP using
curl, which introduces a new external API call flow and handling of user email/OTP values. Impact is limited to thetruefoundry-onboardskill documentation/allowed-tools, but mistakes could break onboarding or leak sensitive inputs in command history.Overview
The
truefoundry-onboardskill now supports creating a new TrueFoundry tenant from the session via email OTP, in addition to accepting an existing tenant URL.It adds
curlas an allowed tool and documents calling the hosted registration service (overrideable viaTFY_REGISTRATION_SERVER_URL) to initiate/complete OTP signup, extractTENANT_URLfrom the response, and then runtfy loginusing that URL.Reviewed by Cursor Bugbot for commit 704d248. Bugbot is set up for automated code reviews on this repo. Configure here.