Add AgentDraftSession as private class#10
Closed
chiragjn wants to merge 1 commit into
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Medium Risk
Session inheritance and typing changes touch core turn/session APIs; behavior should stay equivalent for existing AgentSession users, but draft sessions share session endpoints and optional agent_name differs from production sessions.
Overview
Introduces private
AgentDraftSession/AsyncAgentDraftSessionfor draft agent sessions with an inlineAgentSpec, plusupdate(agent_spec)that PATCHes the draft session and refreshes localagent_specandupdated_at.To support that,
AgentSessionis refactored intoBaseAgentSession/AsyncBaseAgentSession(shared identity + turn/event helpers) and thinAgentSession/AsyncAgentSessionsubclasses that only add requiredagent_name.Turn,PreparedTurn, and turn pager wrappers now type against the base session classes so draft sessions can run the same turn flow.BaseAgentSessionandAsyncBaseAgentSessionare exported from the public agents package; draft session types stay underagents.privatevia existing private re-exports.Reviewed by Cursor Bugbot for commit 51cb7de. Bugbot is set up for automated code reviews on this repo. Configure here.