NAS-139627 / 26.0.0-BETA.1 / NTB: ntb_transport: Preallocate memory windows#240
Merged
amotin merged 1 commit intotruenas/linux-6.18from Feb 11, 2026
Merged
NAS-139627 / 26.0.0-BETA.1 / NTB: ntb_transport: Preallocate memory windows#240amotin merged 1 commit intotruenas/linux-6.18from
amotin merged 1 commit intotruenas/linux-6.18from
Conversation
|
🤖 Claude is monitoring this PR I'll review code, respond to comments, and investigate CI failures.
|
Original Linux code allocated memory on every link up and freed on every link down. It may be a problem to allocate several MBs of physically contiguous memory on a running system. To workaround that, speculatively pre-allocate it on boot and then reallocate only if remote host requests different parameters, which should be very rare.
ixhamza
approved these changes
Feb 11, 2026
|
LGTM! Reviewed the NTB transport memory window DMA buffer pre-allocation changes, and everything looks solid. The approach to allocate buffers at probe time and maintain them across link cycles should effectively prevent the expensive contiguous memory allocation failures. |
|
This PR has been merged and conversations have been locked. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Original Linux code allocated memory on every link up and freed on every link down. It may be a problem to allocate several MBs of physically contiguous memory on a running system. To workaround that, speculatively pre-allocate it on boot and then reallocate only if remote host requests different parameters, which should be very rare.
This replicates the logic we used on FreeBSD.