[dev] [Marfuen] mariano/people-settings-bg-check-toggle by github-actions[bot] · Pull Request #2748 · trycompai/comp

github-actions · 2026-05-05T10:58:41Z

This is an automated pull request to merge mariano/people-settings-bg-check-toggle into dev.
It was created by the [Auto Pull Request] action.

Summary by cubic

Add org-level and per-member background check controls, with permission-gated People Settings and an employee-level exempt toggle. Exempt members count as complete, UI stays in sync across header/list/toggles, and org-level off overrides per-member settings.

New Features
- People > Settings tab: toggle to require background checks (PATCH /v1/organization with backgroundCheckStepEnabled), shown only if the user has organization:update (custom roles supported).
- Employee profile: toggle to exempt a member (PATCH /v1/people/:id with backgroundCheckExempt), gated by member:update; shows an exempt info card; hides the BG-check counter and verified tick; respects org-level off.
- People score: exempt members are treated as complete; background-check and exempt queries run only when the step is enabled.
- API/tests: DTOs/selects now include backgroundCheckExempt; tests added for controllers, people score, header/list UI, settings, and exempt state resync.
Migration
- Adds Member.backgroundCheckExempt BOOLEAN DEFAULT false. Run database migrations; no data changes needed.

^{Written for commit 3cb8b44. Summary will update on new commits.}

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

Add getExemptMemberIds helper and update computePeopleScore to skip the background check requirement for members with backgroundCheckExempt=true. Both the BG-check query and exempt query are gated behind backgroundCheckStepEnabled. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

@IsOptional

- Add backgroundCheckExempt field to UpdatePeopleDto with @IsOptional + @isboolean decorators - Add backgroundCheckExempt: true to MemberQueries.MEMBER_SELECT so the field flows to responses - Add @db mock and backgroundCheckExempt controller test; fix transitive enum mocks so the suite runs Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

Replace manual role-string parsing with resolveBuiltInPermissions + hasPermission for the canManageOrgSettings server-side gate, and add usePermissions self-defense inside PeopleSettings to disable the Switch when the user lacks organization:update. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

Add memberBackgroundCheckExempt prop to EmployeeBackgroundCheck with an ExemptToggleCard that PATCHes /v1/people/:id on change; gate on member:update permission. Also fix @trycompai/billing vitest alias and backgroundCheckExempt default in createMockMember. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

…ull guard Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

vercel · 2026-05-05T10:58:46Z

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated (UTC)
app	Ready	Preview, Comment	May 5, 2026 11:40am
comp-framework-editor	Ready	Preview, Comment	May 5, 2026 11:40am

1 Skipped Deployment

Project	Deployment	Actions	Updated (UTC)
portal	Skipped		May 5, 2026 11:40am

cubic-dev-ai

2 issues found across 24 files

Confidence score: 3/5

There is a concrete user-impacting permission regression in apps/app/src/app/(app)/[orgId]/people/page.tsx: the check ignores custom role permissions, so users with custom organization:update can be incorrectly blocked from the new Settings tab.
apps/app/src/app/(app)/[orgId]/people/[employeeId]/components/Employee.tsx has a state-sync issue where the verified badge can remain stale after exemption toggles, which can mislead users even if backend state is correct.
Given the high confidence and user-facing behavior impact, this sits at moderate merge risk rather than a low-risk cleanup.
Pay close attention to apps/app/src/app/(app)/[orgId]/people/page.tsx and apps/app/src/app/(app)/[orgId]/people/[employeeId]/components/Employee.tsx - permission gating and UI state synchronization need validation.

Prompt for AI agents (unresolved issues)


Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="apps/app/src/app/(app)/[orgId]/people/page.tsx">

<violation number="1" location="apps/app/src/app/(app)/[orgId]/people/page.tsx:39">
P2: This check ignores custom role permissions, so users with custom `organization:update` access can be incorrectly blocked from the new Settings tab.</violation>
</file>

<file name="apps/app/src/app/(app)/[orgId]/people/[employeeId]/components/Employee.tsx">

<violation number="1" location="apps/app/src/app/(app)/[orgId]/people/[employeeId]/components/Employee.tsx:87">
P2: Keep the exemption state in sync with the header; right now the verified badge can stay stale after toggling exemption.</violation>
</file>

_{Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review, or fix all with cubic.}

…h header Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

cubic-dev-ai

1 issue found across 4 files (changes from recent commits).

Prompt for AI agents (unresolved issues)


Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="apps/app/src/app/(app)/[orgId]/people/[employeeId]/components/Employee.tsx">

<violation number="1" location="apps/app/src/app/(app)/[orgId]/people/[employeeId]/components/Employee.tsx:72">
P2: State derived from `memberBackgroundCheckExempt` is not kept in sync with prop updates, which can leave exemption UI stale when upstream data changes.</violation>
</file>

_{Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review, or fix all with cubic.}

Apply the React render-time-adjust pattern in Employee.tsx and EmployeeBackgroundCheck.tsx so that lifted exempt state stays in sync with the prop after router.refresh() or upstream SWR revalidation. Add regression test covering the uncontrolled-mode resync path. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

Marfuen · 2026-05-05T11:23:31Z

@cubic-dev-ai review this again

cubic-dev-ai · 2026-05-05T11:23:36Z

@cubic-dev-ai review this again

@Marfuen I have started the AI code review. It will take a few minutes to complete.

cubic-dev-ai

No issues found across 24 files

Confidence score: 5/5

Automated review surfaced no issues in the provided summaries.
No files require special attention.

claudfuen · 2026-05-05T16:00:56Z

🎉 This PR is included in version 3.43.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Marfuen and others added 10 commits May 5, 2026 10:19

feat(db): add Member.backgroundCheckExempt

3e19936

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

feat(api): allow backgroundCheckStepEnabled in PATCH /v1/organization

c919fdb

feat(app): add People > Settings tab with org-level BG-check toggle

2474526

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

refactor(app): merge duplicate canRequest/canUpdateMember constant

8c8df09

feat(app): hide BG-check counter and tick for exempt members

3172b8f

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

fix(people-settings): address final review — copy + missing tests + n…

9ef0c26

…ull guard Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

github-actions Bot added the automated-pr label May 5, 2026

vercel Bot deployed to Preview – comp-framework-editor May 5, 2026 10:59 View deployment

vercel Bot deployed to Preview – portal May 5, 2026 11:01 View deployment

vercel Bot deployed to Preview – app May 5, 2026 11:03 View deployment

cubic-dev-ai Bot reviewed May 5, 2026

View reviewed changes

Comment thread apps/app/src/app/(app)/[orgId]/people/page.tsx Outdated

Comment thread apps/app/src/app/(app)/[orgId]/people/[employeeId]/components/Employee.tsx Outdated

fix(app): honor custom roles for Settings tab + sync exempt state wit…

dc8a34d

…h header Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

vercel Bot temporarily deployed to Preview – portal May 5, 2026 11:14 Inactive

vercel Bot deployed to Preview – comp-framework-editor May 5, 2026 11:15 View deployment

cubic-dev-ai Bot reviewed May 5, 2026

View reviewed changes

Comment thread apps/app/src/app/(app)/[orgId]/people/[employeeId]/components/Employee.tsx

vercel Bot deployed to Preview – app May 5, 2026 11:18 View deployment

vercel Bot temporarily deployed to Preview – portal May 5, 2026 11:20 Inactive

vercel Bot deployed to Preview – comp-framework-editor May 5, 2026 11:21 View deployment

vercel Bot deployed to Preview – app May 5, 2026 11:25 View deployment

cubic-dev-ai Bot reviewed May 5, 2026

View reviewed changes

Merge branch 'main' into mariano/people-settings-bg-check-toggle

3cb8b44

vercel Bot temporarily deployed to Preview – portal May 5, 2026 11:35 Inactive

Marfuen merged commit bc7ee77 into main May 5, 2026
9 of 14 checks passed

Marfuen deleted the mariano/people-settings-bg-check-toggle branch May 5, 2026 11:36

vercel Bot deployed to Preview – app May 5, 2026 11:39 View deployment

vercel Bot deployed to Preview – comp-framework-editor May 5, 2026 11:40 View deployment

claudfuen added the released label May 5, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[dev] [Marfuen] mariano/people-settings-bg-check-toggle#2748

[dev] [Marfuen] mariano/people-settings-bg-check-toggle#2748
Marfuen merged 13 commits into
mainfrom
mariano/people-settings-bg-check-toggle

github-actions Bot commented May 5, 2026 •

edited by cubic-dev-ai Bot

Loading

Uh oh!

vercel Bot commented May 5, 2026 •

edited

Loading

Uh oh!

cubic-dev-ai Bot left a comment

Uh oh!

Uh oh!

Uh oh!

cubic-dev-ai Bot left a comment

Uh oh!

Uh oh!

Marfuen commented May 5, 2026

Uh oh!

cubic-dev-ai Bot commented May 5, 2026

Uh oh!

cubic-dev-ai Bot left a comment

Uh oh!

Uh oh!

claudfuen commented May 5, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

github-actions Bot commented May 5, 2026 • edited by cubic-dev-ai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by cubic

Uh oh!

vercel Bot commented May 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Marfuen commented May 5, 2026

Uh oh!

cubic-dev-ai Bot commented May 5, 2026

Uh oh!

cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

claudfuen commented May 5, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

github-actions Bot commented May 5, 2026 •

edited by cubic-dev-ai Bot

Loading

vercel Bot commented May 5, 2026 •

edited

Loading