Conversation
…d-custom-departments
…ompai/comp into chas/add-custom-departments
…d-custom-departments
…ompai/comp into chas/add-custom-departments
…d-custom-departments
…d-custom-departments
CS-206 [Improvement] - Ability to be able to add Custom departments to be assigned for Policies, Evidence and People
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
There was a problem hiding this comment.
1 issue found
Confidence score: 4/5
- This PR is likely safe to merge, with minimal risk: the main issue is a contract mismatch rather than a runtime failure.
- In
apps/api/src/tasks/tasks.controller.ts,updateTaskallowsdepartment: nullat runtime while OpenAPI still marksdepartmentas a non-nullable string, which can mislead API consumers and generated clients. - Given the moderate-low severity (4/10), impact appears limited to API documentation/schema expectations instead of core task update behavior.
- Pay close attention to
apps/api/src/tasks/tasks.controller.ts- align OpenAPI nullability with actualupdateTaskruntime handling.
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="apps/api/src/tasks/tasks.controller.ts">
<violation number="1" location="apps/api/src/tasks/tasks.controller.ts:895">
P2: `updateTask` accepts `department: null` at runtime, but the OpenAPI request schema still documents department as non-nullable string.</violation>
</file>
Reply with feedback, questions, or to request a fix.
Fix all with cubic | Re-trigger cubic
| frequency?: string; | ||
| integrationScheduleFrequency?: string; | ||
| department?: string; | ||
| department?: string | null; |
Contributor
There was a problem hiding this comment.
P2: updateTask accepts department: null at runtime, but the OpenAPI request schema still documents department as non-nullable string.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At apps/api/src/tasks/tasks.controller.ts, line 895:
<comment>`updateTask` accepts `department: null` at runtime, but the OpenAPI request schema still documents department as non-nullable string.</comment>
<file context>
@@ -858,7 +892,7 @@ export class TasksController {
frequency?: string;
integrationScheduleFrequency?: string;
- department?: string;
+ department?: string | null;
reviewDate?: string;
notRelevantJustification?: string;
</file context>
Contributor
|
🎉 This PR is included in version 3.70.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an automated pull request to release the candidate branch into production, which will trigger a deployment.
It was created by the [Production PR] action.
Summary by cubic
Add support for custom department names across Policies, Tasks, Risks, and People. Converts enum-based departments to strings, with validation and a new UI picker. Addresses CS-206.
New Features
department; Risks filter by custom departments; Swagger updated.Migration
departmentandvisibleToDepartmentsfrom enum to TEXT for Policy, Member, Risk, Task; keep'none'defaults where used.Written for commit ec2c709. Summary will update on new commits.