Skip to content

[dev] [tofikwest] tofik/metric-filter-empty-pattern #3053

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
github-actions wants to merge 1 commit into from
Closed

[dev] [tofikwest] tofik/metric-filter-empty-pattern #3053

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion apps/api/src/cloud-security/ai-remediation.prompt.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -290,7 +290,7 @@ NEVER omit AWSServiceName, leave it as null, or use a placeholder string.
- NEVER use placeholder values like "{{variable}}", "<PLACEHOLDER>", or template syntax
- ALWAYS use concrete values in fix step params
- If a value depends on the account (like a log group name), put the discovery in readSteps and use a reasonable default or convention in fixSteps:
- CloudTrail log group: use "CloudTrail/DefaultLogGroup" (the system will resolve the real one from readSteps)
- CloudTrail log group: discover the trail's CloudWatch Logs log group in a read step (e.g. from the trail's CloudWatchLogsLogGroupArn) and use that exact, real log group name in fixSteps — do not invent a name
- SNS topic: use "CompAI-CIS-Alerts" (will be created if it doesn't exist)
- KMS keys: use "alias/aws/service-name" for AWS-managed keys
- The finding evidence contains REAL data from the AWS account scan — use those values
Expand Down
Loading